Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 49501002: party: Add per country subdivision type restriction

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by pokoli
Modified:
4 days, 7 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -4 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 chunk +2 lines, -0 lines 0 comments Download
M address.py View 3 chunks +64 lines, -4 lines 0 comments Download
M address.xml View 2 chunks +69 lines, -0 lines 1 comment Download
A view/address_subdivision_type_form.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/address_subdivision_type_list.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
pokoli
1 week, 3 days ago (2018-07-05 11:58:17 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/49501002
1 week, 3 days ago (2018-07-05 12:15:58 UTC) #2
ced
4 days, 7 hours ago (2018-07-11 13:23:20 UTC) #3
I do not find very robust to use context to add blindly a domain clause.
I would prefer to have a domain on address depending on the value of a function
field.

https://codereview.tryton.org/49501002/diff/1/address.xml
File address.xml (right):

https://codereview.tryton.org/49501002/diff/1/address.xml#newcode790
address.xml:790: </record>
Where those values come from?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69