Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(343)

Issue 49501002: party: Add per country subdivision type restriction

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by pokoli
Modified:
6 days, 10 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use Array field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -4 lines) Patch
M CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M address.py View 1 4 chunks +61 lines, -4 lines 0 comments Download
M address.xml View 1 2 chunks +69 lines, -0 lines 0 comments Download
A view/address_subdivision_type_form.xml View 1 1 chunk +9 lines, -0 lines 0 comments Download
A view/address_subdivision_type_list.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
4 months, 2 weeks ago (2018-07-05 11:58:17 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/49501002
4 months, 2 weeks ago (2018-07-05 12:15:58 UTC) #2
ced
I do not find very robust to use context to add blindly a domain clause. ...
4 months, 1 week ago (2018-07-11 13:23:20 UTC) #3
pokoli
The main problem with this desing is that we should accept a list of types ...
3 months, 2 weeks ago (2018-08-02 11:08:21 UTC) #4
ced
On 2018/08/02 11:08:21, pokoli wrote: > The main problem with this desing is that we ...
3 months, 2 weeks ago (2018-08-02 11:39:37 UTC) #5
pokoli
On 2018/08/02 11:39:37, ced wrote: > On 2018/08/02 11:08:21, pokoli wrote: > > The main ...
3 months, 2 weeks ago (2018-08-02 11:53:45 UTC) #6
ced
On 2018/08/02 11:53:45, pokoli wrote: > On 2018/08/02 11:39:37, ced wrote: > > On 2018/08/02 ...
3 months, 2 weeks ago (2018-08-02 14:02:38 UTC) #7
ced
On 2018/08/02 14:02:38, ced wrote: > On 2018/08/02 11:53:45, pokoli wrote: > > On 2018/08/02 ...
3 months, 2 weeks ago (2018-08-03 06:42:14 UTC) #8
pokoli
Use Array field
6 days, 10 hours ago (2018-11-11 20:34:22 UTC) #9
reviewbot
6 days, 10 hours ago (2018-11-11 20:38:27 UTC) #10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766