Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(405)

Issue 49501002: party: Add per country subdivision type restriction

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by pokoli
Modified:
1 month, 2 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -4 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 chunk +2 lines, -0 lines 0 comments Download
M address.py View 3 chunks +64 lines, -4 lines 0 comments Download
M address.xml View 2 chunks +69 lines, -0 lines 2 comments Download
A view/address_subdivision_type_form.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/address_subdivision_type_list.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
pokoli
2 months, 2 weeks ago (2018-07-05 11:58:17 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/49501002
2 months, 2 weeks ago (2018-07-05 12:15:58 UTC) #2
ced
I do not find very robust to use context to add blindly a domain clause. ...
2 months, 1 week ago (2018-07-11 13:23:20 UTC) #3
pokoli
The main problem with this desing is that we should accept a list of types ...
1 month, 2 weeks ago (2018-08-02 11:08:21 UTC) #4
ced
On 2018/08/02 11:08:21, pokoli wrote: > The main problem with this desing is that we ...
1 month, 2 weeks ago (2018-08-02 11:39:37 UTC) #5
pokoli
On 2018/08/02 11:39:37, ced wrote: > On 2018/08/02 11:08:21, pokoli wrote: > > The main ...
1 month, 2 weeks ago (2018-08-02 11:53:45 UTC) #6
ced
On 2018/08/02 11:53:45, pokoli wrote: > On 2018/08/02 11:39:37, ced wrote: > > On 2018/08/02 ...
1 month, 2 weeks ago (2018-08-02 14:02:38 UTC) #7
ced
1 month, 2 weeks ago (2018-08-03 06:42:14 UTC) #8
On 2018/08/02 14:02:38, ced wrote:
> On 2018/08/02 11:53:45, pokoli wrote:
> > On 2018/08/02 11:39:37, ced wrote:
> > > On 2018/08/02 11:08:21, pokoli wrote:
> > > > The main problem with this desing is that we should accept a list of
types
> > to
> > > > compose the value of the domain clause, which (correct if I am wrong) is
> not
> > 
> > > > possible to do now with the pyson and I'm not sure how we should desing
> > this. 
> > > > 
> > > > One idea I have is to create a Char function field which returns the
> > available
> > > > types separated by comands and with a Split PYSON function convert them
to
> a
> > > > list
> > > > of values that will be used on the domain. 
> > > > 
> > > > What do you think?
> > > 
> > > What about having a new type of field Array which is like the Dict but for
> > list?
> > 
> > This will work for this use case but I'm not able to see any other usage on
> the
> > client side.
> > Most of the times a XXX2Many field will be used for representing a list of
> > values.
> 
> What about tags? But for sure it will probably mainly be used for PYSON
domain.

Indeed it is a MultiSelection field that we need. And it will be useful for
stock_lot module.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766