Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(560)

Issue 49701002: tryton: Connect dict widgets to the right activate callback

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by ced
Modified:
13 hours, 47 minutes ago
Reviewers:
jeremy, reviewbot
Visibility:
Public.

Description

On activate of Entry and on toggle CheckButton, the parent must be activate. The toggled handler must also be blocked when activate the CheckButton by code to avoid unnecessary callbacks. issue7987

Patch Set 1 #

Patch Set 2 : The toggled handler must be deactivated when setting value #

Patch Set 3 : flake8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M tryton/gui/window/view_form/view/form_gtk/checkbox.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/dictionary.py View 1 2 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7
ced
1 week, 4 days ago (2019-01-11 17:07:24 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/49701002
1 week, 4 days ago (2019-01-11 17:11:49 UTC) #2
ced
The toggled handler must be deactivated when setting value
1 week, 4 days ago (2019-01-11 17:21:43 UTC) #3
reviewbot
https://codereview.tryton.org/49701002/diff/10002/tryton/gui/window/view_form/view/form_gtk/dictionary.py#newcode79 tryton/gui/window/view_form/view/form_gtk/dictionary.py:79: E501 line too long (80 > 79 characters) URL: https://codereview.tryton.org/49701002
1 week, 4 days ago (2019-01-11 17:48:07 UTC) #4
ced
flake8
1 week, 4 days ago (2019-01-11 18:32:42 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/49701002
1 week, 4 days ago (2019-01-11 18:37:08 UTC) #6
jeremy
13 hours, 47 minutes ago (2019-01-22 10:47:54 UTC) #7
On 2019/01/11 18:37:08, reviewbot wrote:
> flake8 OK
> URL: https://codereview.tryton.org/49701002

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766