Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 49701002: tryton: Connect dict widgets to the right activate callback (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, jeremy, reviewbot
Visibility:
Public.

Description

On activate of Entry and on toggle CheckButton, the parent must be activate. The toggled handler must also be blocked when activate the CheckButton by code to avoid unnecessary callbacks. issue7987

Patch Set 1 #

Patch Set 2 : The toggled handler must be deactivated when setting value #

Patch Set 3 : flake8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M tryton/gui/window/view_form/view/form_gtk/checkbox.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/dictionary.py View 1 2 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10
ced
2 months, 1 week ago (2019-01-11 17:07:24 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/49701002
2 months, 1 week ago (2019-01-11 17:11:49 UTC) #2
ced
The toggled handler must be deactivated when setting value
2 months, 1 week ago (2019-01-11 17:21:43 UTC) #3
reviewbot
https://codereview.tryton.org/49701002/diff/10002/tryton/gui/window/view_form/view/form_gtk/dictionary.py#newcode79 tryton/gui/window/view_form/view/form_gtk/dictionary.py:79: E501 line too long (80 > 79 characters) URL: https://codereview.tryton.org/49701002
2 months, 1 week ago (2019-01-11 17:48:07 UTC) #4
ced
flake8
2 months, 1 week ago (2019-01-11 18:32:42 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/49701002
2 months, 1 week ago (2019-01-11 18:37:08 UTC) #6
jeremy
On 2019/01/11 18:37:08, reviewbot wrote: > flake8 OK > URL: https://codereview.tryton.org/49701002 lgtm
2 months ago (2019-01-22 10:47:54 UTC) #7
rietveld-bot_tryton.org
New changeset ef414bb17b26 by Cédric Krier in branch 'default': Connect dict widgets to the right ...
1 month, 3 weeks ago (2019-01-30 08:34:07 UTC) #8
rietveld-bot_tryton.org
New changeset be0eb03a1670 by Cédric Krier in branch 'default': Connect dict widgets to the right ...
1 month, 3 weeks ago (2019-01-30 08:34:08 UTC) #9
rietveld-bot_tryton.org
1 month, 1 week ago (2019-02-10 22:51:01 UTC) #10
New changeset 373a4ca6ec6c by Cédric Krier in branch '5.0':
Connect dict widgets to the right activate callback
https://hg.tryton.org/tryton/rev/373a4ca6ec6c


New changeset f63e214bdd80 by Cédric Krier in branch '4.8':
Connect dict widgets to the right activate callback
https://hg.tryton.org/tryton/rev/f63e214bdd80


New changeset 0d9abee4f0b0 by Cédric Krier in branch '4.6':
Connect dict widgets to the right activate callback
https://hg.tryton.org/tryton/rev/0d9abee4f0b0


New changeset 7996183413d2 by Cédric Krier in branch '4.4':
Connect dict widgets to the right activate callback
https://hg.tryton.org/tryton/rev/7996183413d2


New changeset 3b94212c9045 by Cédric Krier in branch '4.2':
Connect dict widgets to the right activate callback
https://hg.tryton.org/tryton/rev/3b94212c9045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766