Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 50451002: account_asset: Correctly compute depreciation values with out of range dates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 3 weeks ago by pokoli
Modified:
4 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Asset lines may be empty when the asset does not have any line in the date range. We should not compute the values from the lines on such cases but use the asset start values. issue7395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M asset.py View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5
pokoli
5 months, 3 weeks ago (2018-05-25 15:31:08 UTC) #1
reviewbot
https://codereview.tryton.org/50451002/diff/1/asset.py#newcode49 asset.py:49: E711 comparison to None should be 'if cond is None:' https://codereview.tryton.org/50451002/diff/1/asset.py#newcode912 asset.py:912: E731 ...
5 months, 3 weeks ago (2018-05-25 15:53:48 UTC) #2
ced
LGTM
4 months, 2 weeks ago (2018-07-04 09:46:32 UTC) #3
rietveld-bot_tryton.org
New changeset 59f254dd2f63 by Sergi Almacellas Abellana in branch 'default': Correctly compute depreciation values with ...
4 months, 2 weeks ago (2018-07-04 12:25:24 UTC) #4
rietveld-bot_tryton.org
4 months ago (2018-07-18 18:16:58 UTC) #5
New changeset 52b93f4c8b8b by Sergi Almacellas Abellana in branch '4.8':
Correctly compute depreciation values with out of range dates
https://hg.tryton.org/modules/account_asset/rev/52b93f4c8b8b


New changeset 608f2530705b by Sergi Almacellas Abellana in branch '4.6':
Correctly compute depreciation values with out of range dates
https://hg.tryton.org/modules/account_asset/rev/608f2530705b


New changeset 2d239eff7656 by Sergi Almacellas Abellana in branch '4.4':
Correctly compute depreciation values with out of range dates
https://hg.tryton.org/modules/account_asset/rev/2d239eff7656


New changeset 1a589f0acf53 by Sergi Almacellas Abellana in branch '4.2':
Correctly compute depreciation values with out of range dates
https://hg.tryton.org/modules/account_asset/rev/1a589f0acf53


New changeset 8b51015a2380 by Sergi Almacellas Abellana in branch '4.0':
Correctly compute depreciation values with out of range dates
https://hg.tryton.org/modules/account_asset/rev/8b51015a2380
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766