Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 50561002: account: Enforce party required on account receivable and payable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by ced
Modified:
6 months, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

It is needed to correctly compute the payable and receivable amounts. issue5565

Patch Set 1 #

Patch Set 2 : Add changelog #

Total comments: 1

Patch Set 3 : Improve changelog entry #

Patch Set 4 : Enforce default value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M configuration.py View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M party.py View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12
ced
6 months, 2 weeks ago (2018-09-06 21:06:21 UTC) #1
ced
Add changelog
6 months, 2 weeks ago (2018-09-06 21:20:22 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/50561002
6 months, 2 weeks ago (2018-09-06 21:27:35 UTC) #3
pokoli
https://codereview.tryton.org/50561002/diff/20001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/50561002/diff/20001/CHANGELOG#newcode1 CHANGELOG:1: * Set party required on account payable and receivable ...
6 months, 2 weeks ago (2018-09-06 22:00:45 UTC) #4
ced
Improve changelog entry
6 months, 2 weeks ago (2018-09-06 22:14:51 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/50561002
6 months, 2 weeks ago (2018-09-06 22:31:41 UTC) #6
pokoli
Should we apply the party required also for default_accounts? http://hg.tryton.org/modules/account/file/57b77b859775/configuration.py#l22
6 months, 2 weeks ago (2018-09-07 13:21:42 UTC) #7
ced
Enforce default value
6 months, 2 weeks ago (2018-09-07 13:42:01 UTC) #8
pokoli
LGTM
6 months, 2 weeks ago (2018-09-07 13:50:24 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/50561002
6 months, 2 weeks ago (2018-09-07 13:54:33 UTC) #10
rietveld-bot_tryton.org
New changeset 8c42288a445a by Cédric Krier in branch 'default': Enforce party required on account receivable ...
6 months, 1 week ago (2018-09-10 22:20:09 UTC) #11
rietveld-bot_tryton.org
6 months, 1 week ago (2018-09-10 22:20:22 UTC) #12
New changeset 9e8116f7ff26 by Cédric Krier in branch 'default':
Enforce party required on account receivable and payable
https://hg.tryton.org/tryton-env/rev/9e8116f7ff26
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766