Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 50671002: trytond: Allow to delete record from XML with noupdate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ced
Modified:
2 months, 2 weeks ago
Reviewers:
dave, reviewbot, rietveld-bot, pokoli
Visibility:
Public.

Description

We set the db_id to None to avoid to link later to a different record. issue7668

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Total comments: 2

Patch Set 3 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -12 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M trytond/convert.py View 1 3 chunks +10 lines, -1 line 0 comments Download
M trytond/ir/model.py View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M trytond/model/modelstorage.py View 1 2 2 chunks +22 lines, -8 lines 0 comments Download
M trytond/tests/test_modelstorage.py View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 12
ced
3 months ago (2018-12-22 18:51:07 UTC) #1
reviewbot
https://codereview.tryton.org/50671002/diff/1/trytond/model/modelstorage.py#newcode250 trytond/model/modelstorage.py:250: E501 line too long (82 > 79 characters) https://codereview.tryton.org/50671002/diff/1/trytond/model/modelstorage.py#newcode789 trytond/model/modelstorage.py:789: E501 line too ...
3 months ago (2018-12-22 19:16:20 UTC) #2
dave
Just a minor suggestion. https://codereview.tryton.org/50671002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/50671002/diff/1/CHANGELOG#newcode1 CHANGELOG:1: * Allow to delete record ...
3 months ago (2018-12-23 11:48:18 UTC) #3
ced
https://codereview.tryton.org/50671002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/50671002/diff/1/CHANGELOG#newcode1 CHANGELOG:1: * Allow to delete record from XML with noupdate ...
3 months ago (2018-12-23 14:28:52 UTC) #4
ced
Fix comments
3 months ago (2018-12-23 14:28:54 UTC) #5
reviewbot
https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py#newcode250 trytond/model/modelstorage.py:250: E501 line too long (82 > 79 characters) https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py#newcode789 trytond/model/modelstorage.py:789: E501 line too ...
3 months ago (2018-12-23 14:43:28 UTC) #6
pokoli
https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py#newcode845 trytond/model/modelstorage.py:845: returned as soon as one of the record comes ...
2 months, 4 weeks ago (2018-12-27 10:26:23 UTC) #7
ced
https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://codereview.tryton.org/50671002/diff/20001/trytond/model/modelstorage.py#newcode845 trytond/model/modelstorage.py:845: returned as soon as one of the record comes ...
2 months, 4 weeks ago (2018-12-27 11:36:40 UTC) #8
ced
Update to tip
2 months, 3 weeks ago (2018-12-29 13:54:04 UTC) #9
reviewbot
https://codereview.tryton.org/50671002/diff/30001/trytond/model/modelstorage.py#newcode288 trytond/model/modelstorage.py:288: E501 line too long (82 > 79 characters) https://codereview.tryton.org/50671002/diff/30001/trytond/model/modelstorage.py#newcode847 trytond/model/modelstorage.py:847: E501 line too ...
2 months, 3 weeks ago (2018-12-29 14:08:38 UTC) #10
rietveld-bot_tryton.org
New changeset 04c50d261209 by Cédric Krier in branch 'default': Allow to delete record from XML ...
2 months, 2 weeks ago (2019-01-07 21:09:08 UTC) #11
rietveld-bot_tryton.org
2 months, 2 weeks ago (2019-01-07 21:09:10 UTC) #12
New changeset 45b4f90d9308 by Cédric Krier in branch 'default':
Allow to delete record from XML with noupdate
https://hg.tryton.org/tryton-env/rev/45b4f90d9308
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766