Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(434)

Issue 51361002: tryton-env: Initial commit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by nicoe
Modified:
3 weeks, 2 days ago
Reviewers:
vbastos, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

issue7486 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 32

Patch Set 2 : Fix comments #

Patch Set 3 : Use required start date #

Total comments: 1

Patch Set 4 : Add myself #

Patch Set 5 : Update to tip #

Patch Set 6 : Update INSTALL #

Patch Set 7 : Remove unused import #

Patch Set 8 : Update to tip #

Patch Set 9 : Add python 3.7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1508 lines, -0 lines) Patch
M .hgsub View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A modules/sale_subscription_asset/.drone.yml View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/COPYRIGHT View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/INSTALL View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/LICENSE View 1 2 3 4 5 6 1 chunk +674 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/MANIFEST.in View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/README View 1 2 3 4 5 6 1 chunk +35 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/__init__.py View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/doc/index.rst View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/sale.py View 1 2 3 4 5 6 1 chunk +167 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/sale.xml View 1 2 3 4 5 6 1 chunk +23 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/setup.py View 1 2 3 4 5 6 7 8 1 chunk +123 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/stock.py View 1 2 3 4 5 6 1 chunk +73 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/stock.xml View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/tests/__init__.py View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/tests/scenario_sale_subscription_asset.rst View 1 2 3 4 5 6 1 chunk +165 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/tests/test_sale_subscription_asset.py View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/tox.ini View 1 2 3 4 5 6 7 8 1 chunk +15 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/tryton.cfg View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/view/stock_lot_form.xml View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/view/subscription_line_form.xml View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/view/subscription_line_list.xml View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A modules/sale_subscription_asset/view/subscription_service_form.xml View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 23
nicoe
3 months, 3 weeks ago (2018-06-01 09:59:03 UTC) #1
reviewbot
https://codereview.tryton.org/51361002/diff/1/setup.py#newcode73 setup.py:73: E501 line too long (83 > 79 characters) https://codereview.tryton.org/51361002/diff/1/setup.py#newcode87 setup.py:87: E501 line too ...
3 months, 3 weeks ago (2018-06-01 10:31:12 UTC) #2
ced
https://codereview.tryton.org/51361002/diff/1/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/51361002/diff/1/doc/index.rst#newcode14 doc/index.rst:14: subscription will be run this field will become required. ...
3 months, 3 weeks ago (2018-06-01 13:07:50 UTC) #3
ced
Fix comments
3 months, 3 weeks ago (2018-06-01 18:16:57 UTC) #4
reviewbot
https://codereview.tryton.org/51361002/diff/20001/sale.py#newcode164 sale.py:164: E127 continuation line over-indented for visual indent https://codereview.tryton.org/51361002/diff/20001/sale.py#newcode167 sale.py:167: E127 continuation line over-indented ...
3 months, 3 weeks ago (2018-06-01 18:28:05 UTC) #5
ced
https://codereview.tryton.org/51361002/diff/1/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/51361002/diff/1/doc/index.rst#newcode14 doc/index.rst:14: subscription will be run this field will become required. ...
3 months, 3 weeks ago (2018-06-01 18:30:58 UTC) #6
ced
Use required start date
3 months, 3 weeks ago (2018-06-01 22:42:58 UTC) #7
reviewbot
https://codereview.tryton.org/51361002/diff/40001/sale.py#newcode4 sale.py:4: F401 'Coalesce' imported but unused https://codereview.tryton.org/51361002/diff/40001/sale.py#newcode149 sale.py:149: E127 continuation line over-indented for visual ...
3 months, 3 weeks ago (2018-06-01 22:53:22 UTC) #8
nicoe
https://codereview.tryton.org/51361002/diff/40001/COPYRIGHT File COPYRIGHT (right): https://codereview.tryton.org/51361002/diff/40001/COPYRIGHT#newcode1 COPYRIGHT:1: Copyright (C) 2018 Nicolas Évrard Add yourself here
3 months, 2 weeks ago (2018-06-05 17:01:19 UTC) #9
ced
Add myself
3 months, 2 weeks ago (2018-06-06 06:44:34 UTC) #10
reviewbot
https://codereview.tryton.org/51361002/diff/60001/sale.py#newcode4 sale.py:4: F401 'Coalesce' imported but unused https://codereview.tryton.org/51361002/diff/60001/sale.py#newcode149 sale.py:149: E127 continuation line over-indented for visual ...
3 months, 2 weeks ago (2018-06-06 06:56:55 UTC) #11
ced
Update to tip
2 months, 3 weeks ago (2018-06-28 12:06:30 UTC) #12
ced
Update INSTALL
2 months, 3 weeks ago (2018-06-28 12:06:56 UTC) #13
reviewbot
https://codereview.tryton.org/51361002/diff/100001/sale.py#newcode4 sale.py:4: F401 'Coalesce' imported but unused https://codereview.tryton.org/51361002/diff/100001/sale.py#newcode146 sale.py:146: E127 continuation line over-indented for visual ...
2 months, 3 weeks ago (2018-06-28 12:30:33 UTC) #14
vbastos
On 2018/06/28 12:30:33, reviewbot wrote: > https://codereview.tryton.org/51361002/diff/100001/sale.py#newcode4 > sale.py:4: > F401 'Coalesce' imported but unused ...
1 month, 4 weeks ago (2018-07-26 03:38:19 UTC) #15
ced
On 2018/07/26 03:38:19, vbastos wrote: > On 2018/06/28 12:30:33, reviewbot wrote: > > https://codereview.tryton.org/51361002/diff/100001/sale.py#newcode4 > ...
1 month, 4 weeks ago (2018-07-26 06:30:41 UTC) #16
ced
1 month, 4 weeks ago (2018-07-26 06:31:09 UTC) #17
reviewbot
patch is not applicable URL: https://codereview.tryton.org/51361002
1 month, 4 weeks ago (2018-07-26 06:33:54 UTC) #18
vbastos
Does this codereview have the wrong title?
1 month, 3 weeks ago (2018-07-30 05:53:00 UTC) #19
ced
1 month, 3 weeks ago (2018-07-30 07:50:35 UTC) #20
ced
1 month, 3 weeks ago (2018-07-30 07:53:00 UTC) #21
reviewbot
https://codereview.tryton.org/51361002/diff/160001/modules/sale_subscription_asset/sale.py#newcode145 modules/sale_subscription_asset/sale.py:145: E127 continuation line over-indented for visual indent https://codereview.tryton.org/51361002/diff/160001/modules/sale_subscription_asset/sale.py#newcode148 modules/sale_subscription_asset/sale.py:148: E127 continuation line over-indented ...
1 month, 3 weeks ago (2018-07-30 08:08:22 UTC) #22
rietveld-bot_tryton.org
3 weeks, 2 days ago (2018-08-29 07:19:11 UTC) #23
New changeset 6748b9d3ae32 by Cédric Krier in branch 'default':
Initial commit
https://hg.tryton.org/modules/sale_subscription_asset/rev/6748b9d3ae32
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766