Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 51371002: sale_subscription: Make start date of line required (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by ced
Modified:
2 months, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, nicoe, reviewbot
Visibility:
Public.

Description

This simplifies the usage of start/end date of the line. issue7487

Patch Set 1 #

Total comments: 3

Patch Set 2 : Optimize migration SQL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -18 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M subscription.py View 1 9 chunks +47 lines, -18 lines 0 comments Download
M tests/scenario_sale_subscription.rst View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10
ced
3 months, 3 weeks ago (2018-06-01 22:35:28 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/51371002
3 months, 3 weeks ago (2018-06-01 22:53:01 UTC) #2
nicoe
LGTM
3 months, 1 week ago (2018-06-12 22:13:36 UTC) #3
pokoli
https://codereview.tryton.org/51371002/diff/1/subscription.py File subscription.py (right): https://codereview.tryton.org/51371002/diff/1/subscription.py#newcode510 subscription.py:510: for (line_id, start_date) in cursor: I think we should ...
3 months, 1 week ago (2018-06-13 15:38:24 UTC) #4
ced
https://codereview.tryton.org/51371002/diff/1/subscription.py File subscription.py (right): https://codereview.tryton.org/51371002/diff/1/subscription.py#newcode510 subscription.py:510: for (line_id, start_date) in cursor: On 2018/06/13 15:38:24, pokoli ...
3 months, 1 week ago (2018-06-13 16:00:06 UTC) #5
pokoli
https://codereview.tryton.org/51371002/diff/1/subscription.py File subscription.py (right): https://codereview.tryton.org/51371002/diff/1/subscription.py#newcode510 subscription.py:510: for (line_id, start_date) in cursor: On 2018/06/13 16:00:06, ced ...
3 months, 1 week ago (2018-06-14 08:23:08 UTC) #6
ced
Optimize migration SQL
3 months ago (2018-06-18 07:20:19 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/51371002
3 months ago (2018-06-18 07:26:59 UTC) #8
pokoli
LGTM
3 months ago (2018-06-18 08:08:46 UTC) #9
rietveld-bot_tryton.org
2 months, 4 weeks ago (2018-06-24 14:41:48 UTC) #10
New changeset 3fd4edcc378d by Cédric Krier in branch 'default':
Make start date of line required
https://hg.tryton.org/modules/sale_subscription/rev/3fd4edcc378d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766