Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 51461002: tryton-env: Use passlib

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by ced
Modified:
1 week, 2 days ago
Reviewers:
reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add doc #

Patch Set 3 : Adapt web_user and update tests #

Patch Set 4 : Update hash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -62 lines) Patch
M modules/web_user/tests/test_web_user.py View 1 2 2 chunks +2 lines, -20 lines 0 comments Download
M modules/web_user/user.py View 1 2 3 3 chunks +27 lines, -9 lines 0 comments Download
M trytond/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/topics/configuration.rst View 1 1 chunk +9 lines, -0 lines 0 comments Download
M trytond/doc/topics/install.rst View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/setup.py View 1 chunk +2 lines, -1 line 0 comments Download
M trytond/trytond/res/user.py View 4 chunks +35 lines, -8 lines 0 comments Download
M trytond/trytond/tests/test_user.py View 1 2 4 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 8
ced
1 week, 3 days ago (2018-08-07 20:57:11 UTC) #1
reviewbot
https://codereview.tryton.org/51461002/diff/1/trytond/setup.py#newcode74 trytond/setup.py:74: E501 line too long (85 > 79 characters) https://codereview.tryton.org/51461002/diff/1/trytond/trytond/res/user.py#newcode628 trytond/trytond/res/user.py:628: E712 comparison to ...
1 week, 3 days ago (2018-08-07 21:04:26 UTC) #2
ced
1 week, 3 days ago (2018-08-08 10:22:42 UTC) #3
reviewbot
https://codereview.tryton.org/51461002/diff/20001/trytond/setup.py#newcode74 trytond/setup.py:74: E501 line too long (85 > 79 characters) https://codereview.tryton.org/51461002/diff/20001/trytond/trytond/res/user.py#newcode628 trytond/trytond/res/user.py:628: E712 comparison to ...
1 week, 3 days ago (2018-08-08 10:38:56 UTC) #4
ced
1 week, 3 days ago (2018-08-08 17:46:58 UTC) #5
reviewbot
https://codereview.tryton.org/51461002/diff/40001/modules/web_user/user.py#newcode93 modules/web_user/user.py:93: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 week, 3 days ago (2018-08-08 18:04:22 UTC) #6
ced
1 week, 2 days ago (2018-08-08 21:15:12 UTC) #7
reviewbot
1 week, 2 days ago (2018-08-08 21:39:15 UTC) #8
https://codereview.tryton.org/51461002/diff/60001/modules/web_user/user.py#ne...
modules/web_user/user.py:95:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/51461002/diff/60001/trytond/setup.py#newcode74
trytond/setup.py:74:
E501 line too long (85 > 79 characters)

https://codereview.tryton.org/51461002/diff/60001/trytond/trytond/res/user.py...
trytond/trytond/res/user.py:628:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/51461002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69