Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 51491002: project_invoice: Merge invoice method on effort and on progress

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
3 days, 14 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unused pool #

Total comments: 7

Patch Set 3 : Fix comments and update docs #

Patch Set 4 : Add parameter on all methods #

Total comments: 2

Patch Set 5 : Use progress threshold instead of completed boolean flag #

Patch Set 6 : Update to tip #

Total comments: 1

Patch Set 7 : Add threshold as work field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -95 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M tests/scenario_project_invoice_multiple_party.rst View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
M tests/scenario_project_invoice_threshold.rst View 1 2 3 4 5 6 5 chunks +25 lines, -9 lines 0 comments Download
M tests/test_project_invoice.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M view/work_form.xml View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M work.py View 1 2 3 4 5 6 10 chunks +56 lines, -76 lines 0 comments Download

Messages

Total messages: 22
pokoli
2 months, 3 weeks ago (2018-08-28 14:45:42 UTC) #1
reviewbot
https://codereview.tryton.org/51491002/diff/1/work.py#newcode469 work.py:469: F841 local variable 'pool' is assigned to but never used URL: https://codereview.tryton.org/51491002
2 months, 3 weeks ago (2018-08-28 15:02:58 UTC) #2
pokoli
Remove unused pool
2 months, 3 weeks ago (2018-08-28 16:14:48 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/51491002
2 months, 3 weeks ago (2018-08-28 16:31:53 UTC) #4
ced
https://codereview.tryton.org/51491002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/51491002/diff/20001/work.py#newcode72 work.py:72: table = cls.__table_handler__(module_name) must be instantiated after the super ...
2 months, 3 weeks ago (2018-08-29 06:58:46 UTC) #5
ced
documentation must be updated.
2 months, 3 weeks ago (2018-08-29 06:59:15 UTC) #6
pokoli
Fix comments and update docs
2 months, 2 weeks ago (2018-08-29 12:17:27 UTC) #7
pokoli
https://codereview.tryton.org/51491002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/51491002/diff/20001/work.py#newcode132 work.py:132: def _get_invoiced_duration_effort(cls, works): On 2018/08/29 06:58:45, ced wrote: > ...
2 months, 2 weeks ago (2018-08-29 12:17:45 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/51491002
2 months, 2 weeks ago (2018-08-29 12:27:11 UTC) #9
ced
https://codereview.tryton.org/51491002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/51491002/diff/20001/work.py#newcode132 work.py:132: def _get_invoiced_duration_effort(cls, works): On 2018/08/29 12:17:45, pokoli wrote: > ...
2 months, 2 weeks ago (2018-08-29 12:41:19 UTC) #10
pokoli
Add parameter on all methods
2 months, 2 weeks ago (2018-08-29 14:54:23 UTC) #11
pokoli
https://codereview.tryton.org/51491002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/51491002/diff/20001/work.py#newcode132 work.py:132: def _get_invoiced_duration_effort(cls, works): On 2018/08/29 12:41:19, ced wrote: > ...
2 months, 2 weeks ago (2018-08-29 14:54:40 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/51491002
2 months, 2 weeks ago (2018-08-29 15:22:56 UTC) #13
ced
Maybe we could have a single method + an argument which define the threshold to ...
2 months, 2 weeks ago (2018-08-30 13:53:58 UTC) #14
pokoli
Use progress threshold instead of completed boolean flag
2 months, 2 weeks ago (2018-09-01 09:43:51 UTC) #15
pokoli
https://codereview.tryton.org/51491002/diff/60001/work.py File work.py (right): https://codereview.tryton.org/51491002/diff/60001/work.py#newcode133 work.py:133: return cls._get_invoiced_duration_progress(works, completed=True) On 2018/08/30 13:53:58, ced wrote: > ...
2 months, 2 weeks ago (2018-09-01 09:44:11 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/51491002
2 months, 2 weeks ago (2018-09-01 09:58:07 UTC) #17
pokoli
Update to tip
1 week, 3 days ago (2018-11-07 16:22:48 UTC) #18
reviewbot
flake8 OK URL: https://codereview.tryton.org/51491002
1 week, 3 days ago (2018-11-07 16:37:25 UTC) #19
ced
I'm wondering if the threshold should not be a field on the work. So we ...
3 days, 23 hours ago (2018-11-14 08:26:38 UTC) #20
pokoli
Add threshold as work field
3 days, 14 hours ago (2018-11-14 17:51:26 UTC) #21
reviewbot
3 days, 14 hours ago (2018-11-14 18:06:34 UTC) #22
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766