Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1747)

Issue 51521002: goocalendar: Add single day view (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by pokoli
Modified:
9 hours, 56 minutes ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

bug17

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix ced's comments #

Total comments: 2

Patch Set 3 : Factorize code and remove unneede change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -19 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M examples/simple.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M goocalendar/_calendar.py View 1 2 12 chunks +88 lines, -19 lines 0 comments Download
M goocalendar/util.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
1 month ago (2018-09-12 15:07:45 UTC) #1
reviewbot
https://codereview.tryton.org/51521002/diff/1/goocalendar/_calendar.py#newcode646 goocalendar/_calendar.py:646: E303 too many blank lines (2) URL: https://codereview.tryton.org/51521002
1 month ago (2018-09-12 15:31:55 UTC) #2
ced
https://codereview.tryton.org/51521002/diff/1/examples/simple.py File examples/simple.py (right): https://codereview.tryton.org/51521002/diff/1/examples/simple.py#newcode3 examples/simple.py:3: from __future__ import print_function Not for this patch. https://codereview.tryton.org/51521002/diff/1/examples/simple.py#newcode36 ...
1 week, 5 days ago (2018-10-03 16:57:42 UTC) #3
pokoli
Fix ced's comments
1 week, 4 days ago (2018-10-04 13:48:38 UTC) #4
reviewbot
https://codereview.tryton.org/51521002/diff/20001/examples/simple.py#newcode11 examples/simple.py:11: E901 SyntaxError: invalid syntax URL: https://codereview.tryton.org/51521002
1 week, 4 days ago (2018-10-04 13:57:56 UTC) #5
ced
https://codereview.tryton.org/51521002/diff/20001/goocalendar/_calendar.py File goocalendar/_calendar.py (right): https://codereview.tryton.org/51521002/diff/20001/goocalendar/_calendar.py#newcode203 goocalendar/_calendar.py:203: new_date = util.next_day(cal, self.selected_date) Maybe we could factorise the ...
1 week, 4 days ago (2018-10-04 14:18:44 UTC) #6
pokoli
Factorize code and remove unneede change
1 week ago (2018-10-08 07:53:39 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/51521002
1 week ago (2018-10-08 08:03:52 UTC) #8
ced
LGTM
1 week ago (2018-10-08 08:18:21 UTC) #9
rietveld-bot_tryton.org
9 hours, 56 minutes ago (2018-10-15 13:58:23 UTC) #10
New changeset 3bfd3e59d41a by Sergi Almacellas Abellana in branch 'default':
Add single day view
https://hg.tryton.org/goocalendar/rev/3bfd3e59d41a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766