Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(875)

Issue 51551002: account_uk: Initial revision

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by dave
Modified:
2 days, 5 hours ago
Reviewers:
ced, pokoli, reviewbot, udono2, udono
Visibility:
Public.

Description

UK Accounts module issue7770

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove CHANGELOG and update docs #

Total comments: 3

Patch Set 3 : Change IDs to have meaningful names #

Total comments: 14

Patch Set 4 : Add party_required and reconcile as suggested #

Total comments: 12

Patch Set 5 : Remove EU Supplier tax rule #

Patch Set 6 : Update to work with review68401002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4774 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
A LICENSE View 1 2 3 4 5 1 chunk +674 lines, -0 lines 0 comments Download
A README View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A account_uk.xml View 1 2 3 4 5 1 chunk +2718 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 1 chunk +124 lines, -0 lines 0 comments Download
A tax_uk.xml View 1 2 3 4 5 1 chunk +1044 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A tests/test_account_uk.py View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 24
dave
7 months, 2 weeks ago (2018-10-05 12:31:05 UTC) #1
reviewbot
https://codereview.tryton.org/51551002/diff/1/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
7 months, 2 weeks ago (2018-10-05 12:59:54 UTC) #2
ced
No need to create a CHANGELOG file, it is created automatically by the release process. ...
7 months, 2 weeks ago (2018-10-09 09:20:18 UTC) #3
dave
Remove CHANGELOG and update docs
7 months, 2 weeks ago (2018-10-09 13:19:03 UTC) #4
reviewbot
https://codereview.tryton.org/51551002/diff/20001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
7 months, 2 weeks ago (2018-10-09 13:22:26 UTC) #5
pokoli
https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: <record model="account.account.type.template" id="assets_b_i"> Is thi b_i code used on ...
7 months, 1 week ago (2018-10-16 08:37:02 UTC) #6
dave
Thanks for taking the time to look at this. https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: ...
7 months, 1 week ago (2018-10-16 13:19:39 UTC) #7
ced
https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: <record model="account.account.type.template" id="assets_b_i"> On 2018/10/16 13:19:38, dave wrote: > ...
7 months, 1 week ago (2018-10-16 13:36:40 UTC) #8
dave
Change IDs to have meaningful names
7 months ago (2018-10-22 23:12:00 UTC) #9
reviewbot
https://codereview.tryton.org/51551002/diff/40001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
7 months ago (2018-10-22 23:26:08 UTC) #10
udono
https://codereview.tryton.org/51551002/diff/40001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/40001/account_uk.xml#newcode871 account_uk.xml:871: <field name="name">Account Chart (UK)</field> You choose a very general ...
6 months ago (2018-11-22 09:34:34 UTC) #11
dave
https://codereview.tryton.org/51551002/diff/40001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/40001/account_uk.xml#newcode871 account_uk.xml:871: <field name="name">Account Chart (UK)</field> On 2018/11/22 09:34:34, udono wrote: ...
6 months ago (2018-11-22 12:02:11 UTC) #12
dave
Add party_required and reconcile as suggested
6 months ago (2018-11-22 12:15:35 UTC) #13
reviewbot
https://codereview.tryton.org/51551002/diff/60001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
6 months ago (2018-11-22 12:42:12 UTC) #14
ced
You should check this change as it will have an impact on the CoA: https://bugs.tryton.org/issue4990 ...
4 months, 3 weeks ago (2018-12-30 18:56:36 UTC) #15
dave
Remove EU Supplier tax rule
4 months, 2 weeks ago (2019-01-07 17:04:56 UTC) #16
dave
https://codereview.tryton.org/51551002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/51551002/diff/60001/doc/index.rst#newcode24 doc/index.rst:24: .. _`trytond_accounting_uk_chart`: https://github.com/lampmantech/trytond_accounting_uk_chart On 2018/12/30 18:56:36, ced wrote: > ...
4 months, 2 weeks ago (2019-01-07 17:05:08 UTC) #17
reviewbot
https://codereview.tryton.org/51551002/diff/80001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
4 months, 2 weeks ago (2019-01-07 17:07:29 UTC) #18
pokoli
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode123 tax_uk.xml:123: <field name="description">Outside the Scope of VAT</field> On 2019/01/07 17:05:08, ...
4 months, 2 weeks ago (2019-01-07 17:19:12 UTC) #19
dave
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode123 tax_uk.xml:123: <field name="description">Outside the Scope of VAT</field> On 2019/01/07 17:19:12, ...
4 months, 2 weeks ago (2019-01-07 17:28:03 UTC) #20
ced
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode1046 tax_uk.xml:1046: <field name="name">UK Supplier (Not VAT Registered)</field> On 2019/01/07 17:05:08, ...
4 months, 2 weeks ago (2019-01-07 17:31:07 UTC) #21
dave
Update to work with review68401002
3 months ago (2019-02-15 21:10:03 UTC) #22
reviewbot
https://codereview.tryton.org/51551002/diff/100001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
3 months ago (2019-02-15 21:46:53 UTC) #23
udono2
2 days, 5 hours ago (2019-05-20 22:01:30 UTC) #24
On 2019/01/07 17:28:03, dave wrote:
> https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml
> File tax_uk.xml (right):
> https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode123
> tax_uk.xml:123: <field name="description">Outside the Scope of VAT</field>
> On 2019/01/07 17:19:12, pokoli wrote:
> > On 2019/01/07 17:05:08, dave wrote:
> > > On 2018/12/30 18:56:36, ced wrote:
> > > > What is the use case of this?
> > > It is used for some goods and services that are defined to be "outside the
> > scope of vat" -
>
https://www.gov.uk/guidance/rates-of-vat-on-different-goods-and-services#intr...
> > In tryton Taxes are not required, so if it's not VAT applicable and should
not
> > be reported to Tax authority, you can use invoice lines without taxes. 
> > So it is really required to have this tax? Or a line without taxes can be
> used?
> Yes, I can't see a good use case for this tax, so I don't think this tax is
> really required. Thanks.

but there can be a slight difference: a product with no tax can be "outside the
scope of vat"
but also it could be a forgotten tax declaration on the product.
A separate tax for "outside the scope of vat" determines the product always and
describes that the product 'has no tax'.
A forgotten tax on a product is also determined and always means: a forgotten
tax on a product.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766