Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(738)

Issue 51551002: account_uk: Initial revision

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by dave
Modified:
21 hours, 19 minutes ago
Reviewers:
pokoli, reviewbot, ced, udono
Visibility:
Public.

Description

UK Accounts module issue7770

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove CHANGELOG and update docs #

Total comments: 3

Patch Set 3 : Change IDs to have meaningful names #

Total comments: 14

Patch Set 4 : Add party_required and reconcile as suggested #

Total comments: 12

Patch Set 5 : Remove EU Supplier tax rule #

Patch Set 6 : Update to work with review68401002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4774 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
A LICENSE View 1 2 3 4 5 1 chunk +674 lines, -0 lines 0 comments Download
A README View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A account_uk.xml View 1 2 3 4 5 1 chunk +2718 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 1 chunk +124 lines, -0 lines 0 comments Download
A tax_uk.xml View 1 2 3 4 5 1 chunk +1044 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A tests/test_account_uk.py View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 23
dave
4 months, 2 weeks ago (2018-10-05 12:31:05 UTC) #1
reviewbot
https://codereview.tryton.org/51551002/diff/1/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
4 months, 2 weeks ago (2018-10-05 12:59:54 UTC) #2
ced
No need to create a CHANGELOG file, it is created automatically by the release process. ...
4 months, 1 week ago (2018-10-09 09:20:18 UTC) #3
dave
Remove CHANGELOG and update docs
4 months, 1 week ago (2018-10-09 13:19:03 UTC) #4
reviewbot
https://codereview.tryton.org/51551002/diff/20001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
4 months, 1 week ago (2018-10-09 13:22:26 UTC) #5
pokoli
https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: <record model="account.account.type.template" id="assets_b_i"> Is thi b_i code used on ...
4 months ago (2018-10-16 08:37:02 UTC) #6
dave
Thanks for taking the time to look at this. https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: ...
4 months ago (2018-10-16 13:19:39 UTC) #7
ced
https://codereview.tryton.org/51551002/diff/20001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/20001/account_uk.xml#newcode24 account_uk.xml:24: <record model="account.account.type.template" id="assets_b_i"> On 2018/10/16 13:19:38, dave wrote: > ...
4 months ago (2018-10-16 13:36:40 UTC) #8
dave
Change IDs to have meaningful names
3 months, 3 weeks ago (2018-10-22 23:12:00 UTC) #9
reviewbot
https://codereview.tryton.org/51551002/diff/40001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
3 months, 3 weeks ago (2018-10-22 23:26:08 UTC) #10
udono
https://codereview.tryton.org/51551002/diff/40001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/40001/account_uk.xml#newcode871 account_uk.xml:871: <field name="name">Account Chart (UK)</field> You choose a very general ...
2 months, 3 weeks ago (2018-11-22 09:34:34 UTC) #11
dave
https://codereview.tryton.org/51551002/diff/40001/account_uk.xml File account_uk.xml (right): https://codereview.tryton.org/51551002/diff/40001/account_uk.xml#newcode871 account_uk.xml:871: <field name="name">Account Chart (UK)</field> On 2018/11/22 09:34:34, udono wrote: ...
2 months, 3 weeks ago (2018-11-22 12:02:11 UTC) #12
dave
Add party_required and reconcile as suggested
2 months, 3 weeks ago (2018-11-22 12:15:35 UTC) #13
reviewbot
https://codereview.tryton.org/51551002/diff/60001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
2 months, 3 weeks ago (2018-11-22 12:42:12 UTC) #14
ced
You should check this change as it will have an impact on the CoA: https://bugs.tryton.org/issue4990 ...
1 month, 2 weeks ago (2018-12-30 18:56:36 UTC) #15
dave
Remove EU Supplier tax rule
1 month, 1 week ago (2019-01-07 17:04:56 UTC) #16
dave
https://codereview.tryton.org/51551002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/51551002/diff/60001/doc/index.rst#newcode24 doc/index.rst:24: .. _`trytond_accounting_uk_chart`: https://github.com/lampmantech/trytond_accounting_uk_chart On 2018/12/30 18:56:36, ced wrote: > ...
1 month, 1 week ago (2019-01-07 17:05:08 UTC) #17
reviewbot
https://codereview.tryton.org/51551002/diff/80001/setup.py#newcode85 setup.py:85: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/51551002
1 month, 1 week ago (2019-01-07 17:07:29 UTC) #18
pokoli
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode123 tax_uk.xml:123: <field name="description">Outside the Scope of VAT</field> On 2019/01/07 17:05:08, ...
1 month, 1 week ago (2019-01-07 17:19:12 UTC) #19
dave
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode123 tax_uk.xml:123: <field name="description">Outside the Scope of VAT</field> On 2019/01/07 17:19:12, ...
1 month, 1 week ago (2019-01-07 17:28:03 UTC) #20
ced
https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml File tax_uk.xml (right): https://codereview.tryton.org/51551002/diff/60001/tax_uk.xml#newcode1046 tax_uk.xml:1046: <field name="name">UK Supplier (Not VAT Registered)</field> On 2019/01/07 17:05:08, ...
1 month, 1 week ago (2019-01-07 17:31:07 UTC) #21
dave
Update to work with review68401002
21 hours, 55 minutes ago (2019-02-15 21:10:03 UTC) #22
reviewbot
21 hours, 19 minutes ago (2019-02-15 21:46:53 UTC) #23
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766