Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 51561002: account: Update tax code lines when updating chart from template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by pokoli
Modified:
3 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Also don't compare value with it's template when computing values to update issue7795

Patch Set 1 #

Patch Set 2 : Add update chart test #

Total comments: 4

Patch Set 3 : Use create chart and fix comments #

Patch Set 4 : Fix flake8 #

Patch Set 5 : Move test scenario to new issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tax.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16
pokoli
3 months ago (2018-10-18 15:43:09 UTC) #1
ced
LGTM
3 months ago (2018-10-18 15:46:37 UTC) #2
reviewbot
flake8 OK URL: https://codereview.tryton.org/51561002
3 months ago (2018-10-18 15:58:52 UTC) #3
pokoli
Add update chart test
3 months ago (2018-10-18 17:15:06 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/51561002
3 months ago (2018-10-18 17:23:18 UTC) #5
ced
https://codereview.tryton.org/51561002/diff/20001/tests/test_account.py File tests/test_account.py (right): https://codereview.tryton.org/51561002/diff/20001/tests/test_account.py#newcode1207 tests/test_account.py:1207: session_id, _, _ = CreateChart.create() Can't you use create_chart ...
3 months ago (2018-10-19 09:35:20 UTC) #6
pokoli
Use create chart and fix comments
3 months ago (2018-10-19 14:59:03 UTC) #7
reviewbot
https://codereview.tryton.org/51561002/diff/40001/tests/test_account.py#newcode1086 tests/test_account.py:1086: F841 local variable 'TaxCodeTemplate' is assigned to but never used https://codereview.tryton.org/51561002/diff/40001/tests/test_account.py#newcode1088 tests/test_account.py:1088: F841 ...
3 months ago (2018-10-19 14:59:30 UTC) #8
pokoli
Fix flake8
3 months ago (2018-10-19 15:00:50 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/51561002
3 months ago (2018-10-19 15:27:46 UTC) #10
pokoli
Move test scenario to new issue
3 months ago (2018-10-20 17:00:50 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/51561002
3 months ago (2018-10-20 17:29:40 UTC) #12
ced
LGTM
3 months ago (2018-10-21 08:44:20 UTC) #13
rietveld-bot_tryton.org
New changeset 98c3e872f0c0 by Sergi Almacellas Abellana in branch 'default': Update tax code lines when ...
3 months ago (2018-10-22 09:34:30 UTC) #14
rietveld-bot_tryton.org
New changeset 7afdf93eb0b5 by Sergi Almacellas Abellana in branch 'default': Update tax code lines when ...
3 months ago (2018-10-22 09:34:39 UTC) #15
rietveld-bot_tryton.org
3 months ago (2018-10-23 17:30:57 UTC) #16
New changeset 25da5477f732 by Sergi Almacellas Abellana in branch '5.0':
Update tax code lines when updating chart from template
https://hg.tryton.org/modules/account/rev/25da5477f732


New changeset 0ce66e56d763 by Sergi Almacellas Abellana in branch '4.8':
Update tax code lines when updating chart from template
https://hg.tryton.org/modules/account/rev/0ce66e56d763
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766