Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 51631002: sao: Call record.cancel when creation fails

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by pokoli
Modified:
5 days, 2 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Return prm and fix 80 cols #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/model.js View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
pokoli
2 weeks ago (2019-03-06 10:46:20 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/51631002
2 weeks ago (2019-03-06 10:48:32 UTC) #2
ced
https://codereview.tryton.org/51631002/diff/267061002/src/model.js File src/model.js (right): https://codereview.tryton.org/51631002/diff/267061002/src/model.js#newcode518 src/model.js:518: this.id = this.model.execute('create', [[values]], context, false)[0]; 80 cols https://codereview.tryton.org/51631002/diff/267061002/src/model.js#newcode520 ...
1 week, 3 days ago (2019-03-10 11:17:18 UTC) #3
pokoli
Return prm and fix 80 cols
5 days, 2 hours ago (2019-03-15 16:27:49 UTC) #4
reviewbot
5 days, 2 hours ago (2019-03-15 16:41:20 UTC) #5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766