Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 52471002: account_invoice: Compare amount in invoice currency against amount_to_pay (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by ced
Modified:
1 month, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The transition_pay should have the same test as the default_ask because amount_to_pay is computed in the invoice currency. Otherwise if the rate is lower the test fail in transition_pay and the empty ask state is tested which raises an exception. issue7192

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix title #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1 line) Patch
M invoice.py View 2 chunks +3 lines, -1 line 0 comments Download
A tests/scenario_invoice_alternate_currency_lower_rate.rst View 1 1 chunk +98 lines, -0 lines 0 comments Download
M tests/test_account_invoice.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
ced
2 months ago (2018-09-13 07:33:17 UTC) #1
reviewbot
https://codereview.tryton.org/52471002/diff/1/invoice.py#newcode606 invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/52471002
2 months ago (2018-09-13 07:33:37 UTC) #2
pokoli
LGTM otherwise https://codereview.tryton.org/52471002/diff/1/tests/scenario_invoice_alternate_currency_lower_rate.rst File tests/scenario_invoice_alternate_currency_lower_rate.rst (right): https://codereview.tryton.org/52471002/diff/1/tests/scenario_invoice_alternate_currency_lower_rate.rst#newcode2 tests/scenario_invoice_alternate_currency_lower_rate.rst:2: Invoice Scenario Alternate Currency Why not including ...
2 months ago (2018-09-16 13:25:23 UTC) #3
ced
Fix title
2 months ago (2018-09-16 16:51:08 UTC) #4
reviewbot
https://codereview.tryton.org/52471002/diff/20001/invoice.py#newcode606 invoice.py:606: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/52471002
2 months ago (2018-09-16 16:51:21 UTC) #5
rietveld-bot_tryton.org
New changeset 2cbd0314a9c0 by Cédric Krier in branch 'default': Compare amount in invoice currency against ...
2 months ago (2018-09-17 15:52:13 UTC) #6
rietveld-bot_tryton.org
New changeset dce1f8434d48 by Cédric Krier in branch 'default': Compare amount in invoice currency against ...
2 months ago (2018-09-17 15:52:28 UTC) #7
rietveld-bot_tryton.org
1 month, 2 weeks ago (2018-10-02 11:07:14 UTC) #8
New changeset 61d5c9abddbe by Cédric Krier in branch '4.8':
Compare amount in invoice currency against amount_to_pay
https://hg.tryton.org/modules/account_invoice/rev/61d5c9abddbe


New changeset 574a9f3f4bb5 by Cédric Krier in branch '4.6':
Compare amount in invoice currency against amount_to_pay
https://hg.tryton.org/modules/account_invoice/rev/574a9f3f4bb5


New changeset 8214dad1fbeb by Cédric Krier in branch '4.4':
Compare amount in invoice currency against amount_to_pay
https://hg.tryton.org/modules/account_invoice/rev/8214dad1fbeb


New changeset ba351225abf5 by Cédric Krier in branch '4.2':
Compare amount in invoice currency against amount_to_pay
https://hg.tryton.org/modules/account_invoice/rev/ba351225abf5


New changeset 11ae645dc5d8 by Cédric Krier in branch '4.0':
Compare amount in invoice currency against amount_to_pay
https://hg.tryton.org/modules/account_invoice/rev/11ae645dc5d8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766