Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 52521002: party: Use country code as local prefix for phone numbers format

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by pokoli
Modified:
6 days, 10 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 14

Patch Set 2 : Fix ced's comments #

Patch Set 3 : Add addresses on depends and use scenario for testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -8 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M contact_mechanism.py View 1 2 5 chunks +31 lines, -8 lines 0 comments Download
A tests/scenario_party_phone_number.rst View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M tests/test_party.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9
pokoli
2 weeks, 1 day ago (2018-11-02 11:06:36 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52521002
2 weeks, 1 day ago (2018-11-02 11:27:57 UTC) #2
ced
https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py File contact_mechanism.py (right): https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py#newcode133 contact_mechanism.py:133: def _get_country_code(self): It is a code for phone only ...
1 week ago (2018-11-10 12:37:05 UTC) #3
pokoli
Fix ced's comments
1 week ago (2018-11-10 16:12:09 UTC) #4
pokoli
https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py File contact_mechanism.py (right): https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py#newcode133 contact_mechanism.py:133: def _get_country_code(self): On 2018/11/10 12:37:05, ced wrote: > It ...
1 week ago (2018-11-10 16:12:20 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/52521002
1 week ago (2018-11-10 16:43:03 UTC) #6
ced
https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py File contact_mechanism.py (right): https://codereview.tryton.org/52521002/diff/1/contact_mechanism.py#newcode146 contact_mechanism.py:146: for address in party.addresses: On 2018/11/10 16:12:20, pokoli wrote: ...
6 days, 11 hours ago (2018-11-11 21:01:50 UTC) #7
pokoli
Add addresses on depends and use scenario for testing
6 days, 10 hours ago (2018-11-11 22:11:05 UTC) #8
reviewbot
6 days, 10 hours ago (2018-11-11 22:39:31 UTC) #9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766