Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1239)

Issue 52521004: account: Do not recursively extend the base domain of parent and childs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by ced
Modified:
1 month, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The base class can not extend domain in __setup__ because it modify the field of the base class. issue7834

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M account.py View 1 chunk +4 lines, -7 lines 0 comments Download
M common.py View 3 chunks +9 lines, -5 lines 2 comments Download
M tax.py View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8
ced
2 months, 3 weeks ago (2018-11-02 16:53:31 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52521004
2 months, 3 weeks ago (2018-11-02 16:55:46 UTC) #2
pokoli
https://codereview.tryton.org/52521004/diff/1/common.py File common.py (right): https://codereview.tryton.org/52521004/diff/1/common.py#newcode37 common.py:37: and hasattr(cls, 'company')): I think it's better to compose ...
2 months, 2 weeks ago (2018-11-06 19:06:52 UTC) #3
ced
https://codereview.tryton.org/52521004/diff/1/common.py File common.py (right): https://codereview.tryton.org/52521004/diff/1/common.py#newcode37 common.py:37: and hasattr(cls, 'company')): On 2018/11/06 19:06:52, pokoli wrote: > ...
2 months, 2 weeks ago (2018-11-06 19:33:31 UTC) #4
pokoli
LGTM
2 months, 2 weeks ago (2018-11-07 14:46:16 UTC) #5
rietveld-bot_tryton.org
New changeset 14ec25c74350 by Cédric Krier in branch 'default': Do not recursively extend the base ...
2 months ago (2018-11-18 11:00:39 UTC) #6
rietveld-bot_tryton.org
New changeset 9051602473e6 by Cédric Krier in branch 'default': Do not recursively extend the base ...
2 months ago (2018-11-18 11:00:43 UTC) #7
rietveld-bot_tryton.org
1 month, 4 weeks ago (2018-11-25 21:00:26 UTC) #8
New changeset b61cd149ae9c by Cédric Krier in branch '5.0':
Do not recursively extend the base domain of parent and childs
https://hg.tryton.org/modules/account/rev/b61cd149ae9c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766