Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 52551002: account_statement: Use invoice amount to pay as line amount when creating lines from origins

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by pokoli
Modified:
5 days, 3 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Factorize code and add new tests scenario #

Patch Set 3 : Add changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -8 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M statement.py View 1 3 chunks +21 lines, -8 lines 0 comments Download
A tests/scenario_statement_origin_multiple_invoices.rst View 1 1 chunk +128 lines, -0 lines 0 comments Download
M tests/test_account_statement.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
pokoli
3 months, 1 week ago (2018-12-10 10:07:58 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
3 months, 1 week ago (2018-12-10 10:15:31 UTC) #2
ced
Missing changelog https://codereview.tryton.org/52551002/diff/1/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/1/statement.py#newcode756 statement.py:756: if abs(self.amount) > abs(amount_to_pay): This is mainly ...
1 week, 3 days ago (2019-03-10 16:47:12 UTC) #3
pokoli
Factorize code and add new tests scenario
5 days, 3 hours ago (2019-03-15 16:02:48 UTC) #4
pokoli
Add changelog
5 days, 3 hours ago (2019-03-15 16:03:31 UTC) #5
reviewbot
5 days, 3 hours ago (2019-03-15 16:15:35 UTC) #6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766