Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2154)

Issue 52551002: account_statement: Use invoice amount to pay as line amount when creating lines from origins (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by pokoli
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Factorize code and add new tests scenario #

Patch Set 3 : Add changelog #

Total comments: 10

Patch Set 4 : Fix comments #

Total comments: 2

Patch Set 5 : Fix comments #

Total comments: 1

Patch Set 6 : Use Statement.on_change_origins #

Total comments: 1

Patch Set 7 : Fix flake8 and remove continue #

Total comments: 1

Patch Set 8 : Copy list instead of appending #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M statement.py View 1 2 3 4 5 6 7 1 chunk +45 lines, -0 lines 0 comments Download
A tests/scenario_statement_origin_invoices.rst View 1 2 3 1 chunk +128 lines, -0 lines 0 comments Download
M tests/test_account_statement.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26
pokoli
5 months, 2 weeks ago (2018-12-10 10:07:58 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
5 months, 2 weeks ago (2018-12-10 10:15:31 UTC) #2
ced
Missing changelog https://codereview.tryton.org/52551002/diff/1/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/1/statement.py#newcode756 statement.py:756: if abs(self.amount) > abs(amount_to_pay): This is mainly ...
2 months, 2 weeks ago (2019-03-10 16:47:12 UTC) #3
pokoli
Factorize code and add new tests scenario
2 months, 1 week ago (2019-03-15 16:02:48 UTC) #4
pokoli
Add changelog
2 months, 1 week ago (2019-03-15 16:03:31 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
2 months, 1 week ago (2019-03-15 16:15:35 UTC) #6
ced
https://codereview.tryton.org/52551002/diff/277111010/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/277111010/statement.py#newcode729 statement.py:729: def _compute_invoice_amount_to_pay(self): I do not like method starting with ...
2 months ago (2019-03-22 15:27:46 UTC) #7
pokoli
Fix comments
2 months ago (2019-03-22 18:35:42 UTC) #8
pokoli
https://codereview.tryton.org/52551002/diff/277111010/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/277111010/statement.py#newcode729 statement.py:729: def _compute_invoice_amount_to_pay(self): On 2019/03/22 15:27:46, ced wrote: > I ...
2 months ago (2019-03-22 18:36:13 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
2 months ago (2019-03-22 18:46:02 UTC) #10
ced
https://codereview.tryton.org/52551002/diff/287141002/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/287141002/statement.py#newcode760 statement.py:760: if self.amount and self.statement and self.statement.journal: No need to ...
2 months ago (2019-03-22 23:04:41 UTC) #11
pokoli
Fix comments
1 month, 4 weeks ago (2019-03-25 19:35:40 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
1 month, 4 weeks ago (2019-03-25 19:44:46 UTC) #13
ced
https://codereview.tryton.org/52551002/diff/283101002/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/283101002/statement.py#newcode785 statement.py:785: # When empty statement.on_change_lines updates the amount value I ...
1 month, 3 weeks ago (2019-03-27 22:13:19 UTC) #14
pokoli
Use Statement.on_change_origins
1 month, 2 weeks ago (2019-04-08 06:49:20 UTC) #15
reviewbot
https://codereview.tryton.org/52551002/diff/269311002/statement.py#newcode254 statement.py:254: F841 local variable 'Line' is assigned to but never used https://codereview.tryton.org/52551002/diff/269311002/statement.py#newcode279 statement.py:279: F841 ...
1 month, 2 weeks ago (2019-04-08 07:07:02 UTC) #16
ced
Please fix the flake8 errors. https://codereview.tryton.org/52551002/diff/269311002/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/269311002/statement.py#newcode285 statement.py:285: continue This will make ...
1 month, 1 week ago (2019-04-11 11:48:59 UTC) #17
pokoli
Fix flake8 and remove continue
1 month, 1 week ago (2019-04-11 12:58:01 UTC) #18
pokoli
1 month, 1 week ago (2019-04-11 12:58:59 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
1 month, 1 week ago (2019-04-11 13:19:44 UTC) #20
ced
https://codereview.tryton.org/52551002/diff/253311002/statement.py File statement.py (right): https://codereview.tryton.org/52551002/diff/253311002/statement.py#newcode293 statement.py:293: lines.append(line) Why not do like in on_change_lines: lines = ...
1 month, 1 week ago (2019-04-12 17:55:38 UTC) #21
pokoli
Copy list instead of appending
1 month, 1 week ago (2019-04-12 19:11:50 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/52551002
1 month, 1 week ago (2019-04-12 19:41:22 UTC) #23
ced
LGTM
1 month, 1 week ago (2019-04-13 12:14:22 UTC) #24
rietveld-bot_tryton.org
New changeset c053ef01407f by Sergi Almacellas Abellana in branch 'default': Use invoice amount to pay ...
1 month, 1 week ago (2019-04-14 12:32:47 UTC) #25
rietveld-bot_tryton.org
1 month, 1 week ago (2019-04-14 12:32:52 UTC) #26
New changeset b470f0318324 by Sergi Almacellas Abellana in branch 'default':
Use invoice amount to pay as line amount when creating lines from origins
https://hg.tryton.org/tryton-env/rev/b470f0318324
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766