Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 52581002: timesheet: Test if origin is ModelStorage instance before calling rec_name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The origin could have a negative id and so the value is a string which is not usable origin for record name. issue7948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M work.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6
ced
2 months, 1 week ago (2019-01-08 09:49:50 UTC) #1
reviewbot
https://codereview.tryton.org/52581002/diff/1/work.py#newcode116 work.py:116: E712 comparison to False should be 'if cond is False:' or 'if not ...
2 months, 1 week ago (2019-01-08 10:15:44 UTC) #2
pokoli
LGTM
2 months, 1 week ago (2019-01-10 17:04:31 UTC) #3
rietveld-bot_tryton.org
New changeset 467f0f8755f0 by Cédric Krier in branch 'default': Test if origin is ModelStorage instance ...
2 months ago (2019-01-14 23:04:10 UTC) #4
rietveld-bot_tryton.org
New changeset 64d06dc2dc7c by Cédric Krier in branch 'default': Test if origin is ModelStorage instance ...
2 months ago (2019-01-14 23:04:18 UTC) #5
rietveld-bot_tryton.org
1 month, 1 week ago (2019-02-10 22:50:07 UTC) #6
New changeset 01c72a4f7cb5 by Cédric Krier in branch '5.0':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/modules/timesheet/rev/01c72a4f7cb5


New changeset 1d083ed343d0 by Cédric Krier in branch '4.8':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/modules/timesheet/rev/1d083ed343d0


New changeset d0bc1cb7d702 by Cédric Krier in branch '4.6':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/modules/timesheet/rev/d0bc1cb7d702


New changeset b4bbe422b1bc by Cédric Krier in branch '4.4':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/modules/timesheet/rev/b4bbe422b1bc


New changeset 8ef86cca35cc by Cédric Krier in branch '4.2':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/modules/timesheet/rev/8ef86cca35cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766