Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(246)

Issue 52581002: timesheet: Test if origin is ModelStorage instance before calling rec_name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by ced
Modified:
1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The origin could have a negative id and so the value is a string which is not usable origin for record name. issue7948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M work.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ced
1 week, 6 days ago (2019-01-08 09:49:50 UTC) #1
reviewbot
https://codereview.tryton.org/52581002/diff/1/work.py#newcode116 work.py:116: E712 comparison to False should be 'if cond is False:' or 'if not ...
1 week, 6 days ago (2019-01-08 10:15:44 UTC) #2
pokoli
LGTM
1 week, 4 days ago (2019-01-10 17:04:31 UTC) #3
rietveld-bot_tryton.org
New changeset 467f0f8755f0 by Cédric Krier in branch 'default': Test if origin is ModelStorage instance ...
1 week ago (2019-01-14 23:04:10 UTC) #4
rietveld-bot_tryton.org
1 week ago (2019-01-14 23:04:18 UTC) #5
New changeset 64d06dc2dc7c by Cédric Krier in branch 'default':
Test if origin is ModelStorage instance before calling rec_name
https://hg.tryton.org/tryton-env/rev/64d06dc2dc7c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766