Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 52591002: trytond: Correctly rename column with sqlite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by ced
Modified:
6 days, 15 hours ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

The table must be recreated if the target column does not exist. Also temporary column name should use double underscore as module may use single underscore. issue7978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M trytond/backend/sqlite/table.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
ced
1 week, 6 days ago (2019-01-08 18:02:35 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52591002
1 week, 6 days ago (2019-01-08 18:07:45 UTC) #2
rietveld-bot_tryton.org
New changeset c4ec4f7d9866 by Cédric Krier in branch 'default': Correctly rename column with SQLite https://hg.tryton.org/trytond/rev/c4ec4f7d9866
6 days, 15 hours ago (2019-01-15 10:30:27 UTC) #3
rietveld-bot_tryton.org
6 days, 15 hours ago (2019-01-15 10:30:32 UTC) #4
New changeset e92a826eec81 by Cédric Krier in branch 'default':
Correctly rename column with SQLite
https://hg.tryton.org/tryton-env/rev/e92a826eec81
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766