Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 52591002: trytond: Correctly rename column with sqlite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

The table must be recreated if the target column does not exist. Also temporary column name should use double underscore as module may use single underscore. issue7978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M trytond/backend/sqlite/table.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
ced
2 months, 1 week ago (2019-01-08 18:02:35 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52591002
2 months, 1 week ago (2019-01-08 18:07:45 UTC) #2
rietveld-bot_tryton.org
New changeset c4ec4f7d9866 by Cédric Krier in branch 'default': Correctly rename column with SQLite https://hg.tryton.org/trytond/rev/c4ec4f7d9866
2 months ago (2019-01-15 10:30:27 UTC) #3
rietveld-bot_tryton.org
New changeset e92a826eec81 by Cédric Krier in branch 'default': Correctly rename column with SQLite https://hg.tryton.org/tryton-env/rev/e92a826eec81
2 months ago (2019-01-15 10:30:32 UTC) #4
rietveld-bot_tryton.org
1 month, 1 week ago (2019-02-10 22:51:26 UTC) #5
New changeset ea510f2ffe05 by Cédric Krier in branch '5.0':
Correctly rename column with SQLite
https://hg.tryton.org/trytond/rev/ea510f2ffe05


New changeset 9c751a18633c by Cédric Krier in branch '4.8':
Correctly rename column with SQLite
https://hg.tryton.org/trytond/rev/9c751a18633c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766