Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 52631002: tryton-docker: Add pygal dependency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by pokoli
Modified:
1 month ago
Reviewers:
rietveld-bot, ced
Visibility:
Public.

Description

The dependency is used by the sale module in order to show sparklines issue8162

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M 4.8/Dockerfile View 1 chunk +1 line, -1 line 0 comments Download
M 5.0/Dockerfile View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 6
pokoli
1 month, 2 weeks ago (2019-03-01 15:25:18 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/52631002
1 month, 2 weeks ago (2019-03-01 15:48:09 UTC) #2
ced
https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile File 5.0/Dockerfile (right): https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile#newcode58 5.0/Dockerfile:58: && pip3 install --no-cache-dir phonenumbers python-stdnum[SOAP] pygal There is ...
1 month, 2 weeks ago (2019-03-01 15:51:20 UTC) #3
pokoli
https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile File 5.0/Dockerfile (right): https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile#newcode58 5.0/Dockerfile:58: && pip3 install --no-cache-dir phonenumbers python-stdnum[SOAP] pygal On 2019/03/01 ...
1 month, 2 weeks ago (2019-03-01 16:26:52 UTC) #4
ced
LGTM https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile File 5.0/Dockerfile (right): https://codereview.tryton.org/52631002/diff/1/5.0/Dockerfile#newcode58 5.0/Dockerfile:58: && pip3 install --no-cache-dir phonenumbers python-stdnum[SOAP] pygal On ...
1 month, 2 weeks ago (2019-03-01 16:39:41 UTC) #5
rietveld-bot_tryton.org
1 month ago (2019-03-15 16:56:12 UTC) #6
New changeset a592e95cd549 by Sergi Almacellas Abellana in branch 'default':
Add pygal dependency
https://hg.tryton.org/tryton-docker/rev/a592e95cd549
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766