Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 53271003: sao: Support width attribute on tree view (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by perilla
Modified:
3 weeks, 5 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Total comments: 6

Patch Set 3 : Fix comments #

Total comments: 4

Patch Set 4 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/view/tree.js View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17
perilla
1 month, 1 week ago (2018-06-05 16:25:14 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/53271003
1 month, 1 week ago (2018-06-05 16:32:10 UTC) #2
ced
https://codereview.tryton.org/53271003/diff/1/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/53271003/diff/1/src/view/tree.js#newcode428 src/view/tree.js:428: }[column.attributes.widget] || 10; So the width attribute should be ...
1 month, 1 week ago (2018-06-06 06:47:45 UTC) #3
ced
https://codereview.tryton.org/53271003/diff/1/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/53271003/diff/1/src/view/tree.js#newcode410 src/view/tree.js:410: column.col.css('width', column.attributes.width * 100 + '%'); The width attribute ...
1 month, 1 week ago (2018-06-06 06:49:37 UTC) #4
perilla
1 month ago (2018-06-13 14:16:06 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/53271003
1 month ago (2018-06-13 14:33:16 UTC) #6
perilla
On 2018/06/06 06:49:37, ced wrote: > https://codereview.tryton.org/53271003/diff/1/src/view/tree.js > File src/view/tree.js (right): > > https://codereview.tryton.org/53271003/diff/1/src/view/tree.js#newcode410 > ...
1 month ago (2018-06-13 16:38:54 UTC) #7
ced
Missing changelog https://codereview.tryton.org/53271003/diff/20001/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/53271003/diff/20001/src/view/tree.js#newcode430 src/view/tree.js:430: var width = default_width[column.attributes.widget] || 10; 80 ...
3 weeks, 6 days ago (2018-06-18 07:12:32 UTC) #8
perilla
3 weeks, 6 days ago (2018-06-18 14:32:13 UTC) #9
perilla
https://codereview.tryton.org/53271003/diff/20001/src/view/tree.js File src/view/tree.js (right): https://codereview.tryton.org/53271003/diff/20001/src/view/tree.js#newcode430 src/view/tree.js:430: var width = default_width[column.attributes.widget] || 10; On 2018/06/18 07:12:31, ...
3 weeks, 6 days ago (2018-06-18 14:34:41 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/53271003
3 weeks, 6 days ago (2018-06-18 14:34:48 UTC) #11
ced
https://codereview.tryton.org/53271003/diff/40001/src/view/tree.js File src/view/tree.js (left): https://codereview.tryton.org/53271003/diff/40001/src/view/tree.js#oldcode426 src/view/tree.js:426: }[column.attributes.widget] || 10; This part could stay there. https://codereview.tryton.org/53271003/diff/40001/src/view/tree.js ...
3 weeks, 6 days ago (2018-06-18 14:41:32 UTC) #12
perilla
3 weeks, 6 days ago (2018-06-18 15:34:12 UTC) #13
perilla
https://codereview.tryton.org/53271003/diff/40001/src/view/tree.js File src/view/tree.js (left): https://codereview.tryton.org/53271003/diff/40001/src/view/tree.js#oldcode426 src/view/tree.js:426: }[column.attributes.widget] || 10; On 2018/06/18 14:41:32, ced wrote: > ...
3 weeks, 6 days ago (2018-06-18 15:34:46 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/53271003
3 weeks, 6 days ago (2018-06-18 15:56:32 UTC) #15
ced
LGTM
3 weeks, 5 days ago (2018-06-19 08:48:16 UTC) #16
rietveld-bot_tryton.org
3 weeks, 5 days ago (2018-06-19 08:48:44 UTC) #17
New changeset 7dba29015e26 by Diego Abad in branch 'default':
Support width attribute on tree view
https://hg.tryton.org/sao/rev/7dba29015e26
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69