Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 53291002: tryton: Add dict value validation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by nicoe
Modified:
6 days, 9 hours ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 13

Patch Set 2 : Fix sql_like quoting and remarks #

Total comments: 4

Patch Set 3 : Remove domain inversion stuffs #

Patch Set 4 : Fix remarks #

Total comments: 6

Patch Set 5 : Apply invalid and required widget accessors in the display #

Patch Set 6 : Loop over value keys #

Patch Set 7 : fix flake8 error #

Total comments: 1

Patch Set 8 : use variable instead of accessing dict #

Patch Set 9 : fix remarks from sao review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -50 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M tryton/client.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 6 7 8 3 chunks +71 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/dictionary.py View 1 2 3 4 5 6 7 8 11 chunks +26 lines, -47 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/widget.py View 1 2 3 4 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 41
nicoe
1 month ago (2018-06-13 17:16:26 UTC) #1
reviewbot
https://codereview.tryton.org/53291002/diff/1/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/1/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month ago (2018-06-13 17:28:12 UTC) #2
ced
https://codereview.tryton.org/53291002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/53291002/diff/1/CHANGELOG#newcode1 CHANGELOG:1: * Add dict value validation Why not: Validate values ...
1 month ago (2018-06-14 07:13:34 UTC) #3
ced
The support for like in domain inversion should be in another patch.
1 month ago (2018-06-14 07:54:01 UTC) #4
pokoli
https://codereview.tryton.org/53291002/diff/1/tryton/client.py File tryton/client.py (right): https://codereview.tryton.org/53291002/diff/1/tryton/client.py#newcode221 tryton/client.py:221: .readonly > entry { IIUC this is separate issue ...
1 month ago (2018-06-14 09:09:29 UTC) #5
ced
https://codereview.tryton.org/53291002/diff/1/tryton/client.py File tryton/client.py (right): https://codereview.tryton.org/53291002/diff/1/tryton/client.py#newcode221 tryton/client.py:221: .readonly > entry { On 2018/06/14 09:09:29, pokoli wrote: ...
1 month ago (2018-06-14 10:29:51 UTC) #6
nicoe
https://codereview.tryton.org/53291002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/53291002/diff/1/CHANGELOG#newcode1 CHANGELOG:1: * Add dict value validation On 2018/06/14 07:13:34, ced ...
1 month ago (2018-06-14 11:02:02 UTC) #7
nicoe
Fix sql_like quoting and remarks
1 month ago (2018-06-14 11:04:47 UTC) #8
nicoe
On 2018/06/14 07:54:01, ced wrote: > The support for like in domain inversion should be ...
1 month ago (2018-06-14 11:08:26 UTC) #9
reviewbot
https://codereview.tryton.org/53291002/diff/20001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/20001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
1 month ago (2018-06-14 11:30:55 UTC) #10
ced
https://codereview.tryton.org/53291002/diff/1/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): https://codereview.tryton.org/53291002/diff/1/tryton/common/domain_inversion.py#newcode603 tryton/common/domain_inversion.py:603: assert not eval_domain(domain, {'x': 'a123b'}) On 2018/06/14 11:02:02, nicoe ...
1 month ago (2018-06-14 11:54:19 UTC) #11
ced
On 2018/06/14 11:08:26, nicoe wrote: > On 2018/06/14 07:54:01, ced wrote: > > The support ...
1 month ago (2018-06-14 11:56:43 UTC) #12
nicoe
* Cédric Krier [2018-06-14 13:56 +0200]: >On 2018/06/14 11:08:26, nicoe wrote: >>On 2018/06/14 07:54:01, ced ...
1 month ago (2018-06-15 09:58:53 UTC) #13
ced
On 2018/06/15 09:58:53, nicoe wrote: > * Cédric Krier [2018-06-14 13:56 +0200]: > >On 2018/06/14 ...
3 weeks, 6 days ago (2018-06-18 06:54:06 UTC) #14
ced
It is missing the get_invalid_widget (and required). I think it can be a property in ...
3 weeks, 6 days ago (2018-06-18 07:09:04 UTC) #15
nicoe
Remove domain inversion stuffs
3 weeks, 6 days ago (2018-06-18 09:24:22 UTC) #16
reviewbot
https://codereview.tryton.org/53291002/diff/40001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/40001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 6 days ago (2018-06-18 09:30:26 UTC) #17
nicoe
Fix remarks
3 weeks, 6 days ago (2018-06-18 11:19:47 UTC) #18
reviewbot
https://codereview.tryton.org/53291002/diff/60001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/60001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 6 days ago (2018-06-18 11:32:31 UTC) #19
ced
https://codereview.tryton.org/53291002/diff/60001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/53291002/diff/60001/CHANGELOG#newcode1 CHANGELOG:1: * Validate dictionnary items value Is it not more ...
3 weeks, 5 days ago (2018-06-19 08:42:28 UTC) #20
nicoe
https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py#newcode1025 tryton/gui/window/view_form/model/field.py:1025: for key, description in self.keys.items(): On 2018/06/18 07:09:04, ced ...
3 weeks, 5 days ago (2018-06-19 11:27:19 UTC) #21
nicoe
Apply invalid and required widget accessors in the display
3 weeks, 5 days ago (2018-06-19 11:28:20 UTC) #22
reviewbot
https://codereview.tryton.org/53291002/diff/80001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/80001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 5 days ago (2018-06-19 11:53:41 UTC) #23
ced
https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py#newcode1025 tryton/gui/window/view_form/model/field.py:1025: for key, description in self.keys.items(): On 2018/06/19 11:27:19, nicoe ...
3 weeks, 5 days ago (2018-06-19 12:38:30 UTC) #24
nicoe
https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/53291002/diff/20001/tryton/gui/window/view_form/model/field.py#newcode1025 tryton/gui/window/view_form/model/field.py:1025: for key, description in self.keys.items(): On 2018/06/19 12:38:30, ced ...
3 weeks, 5 days ago (2018-06-19 14:48:00 UTC) #25
nicoe
Loop over value keys
3 weeks, 5 days ago (2018-06-19 14:48:30 UTC) #26
reviewbot
https://codereview.tryton.org/53291002/diff/100001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/100001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 5 days ago (2018-06-19 15:01:07 UTC) #27
ced
Flake8 errors and it is missing the same change as sao about invalid widget.
3 weeks, 4 days ago (2018-06-20 09:11:13 UTC) #28
nicoe
On 2018/06/20 09:11:13, ced wrote: > it is missing the same change as sao about ...
3 weeks, 4 days ago (2018-06-20 10:56:57 UTC) #29
ced
On 2018/06/20 10:56:57, nicoe wrote: > On 2018/06/20 09:11:13, ced wrote: > > it is ...
3 weeks, 4 days ago (2018-06-20 11:11:23 UTC) #30
ced
On 2018/06/20 11:11:23, ced wrote: > On 2018/06/20 10:56:57, nicoe wrote: > > On 2018/06/20 ...
3 weeks, 4 days ago (2018-06-20 11:27:28 UTC) #31
nicoe
fix flake8 error
3 weeks, 4 days ago (2018-06-20 11:30:29 UTC) #32
reviewbot
https://codereview.tryton.org/53291002/diff/120001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/120001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 4 days ago (2018-06-20 11:34:04 UTC) #33
ced
https://codereview.tryton.org/53291002/diff/120001/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/53291002/diff/120001/tryton/gui/window/view_form/model/field.py#newcode1011 tryton/gui/window/view_form/model/field.py:1011: self.keys[new_field['name']] = new_field Why not having: name = new_field['name'] ...
3 weeks, 4 days ago (2018-06-20 12:49:43 UTC) #34
nicoe
use variable instead of accessing dict
3 weeks, 4 days ago (2018-06-20 15:55:53 UTC) #35
reviewbot
https://codereview.tryton.org/53291002/diff/140001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/140001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 4 days ago (2018-06-20 16:02:14 UTC) #36
ced
LGTM
3 weeks, 4 days ago (2018-06-20 16:16:15 UTC) #37
nicoe
fix remarks from sao review
3 weeks, 2 days ago (2018-06-22 12:58:08 UTC) #38
reviewbot
https://codereview.tryton.org/53291002/diff/160001/tryton/client.py#newcode188 tryton/client.py:188: F401 'goocalendar' imported but unused https://codereview.tryton.org/53291002/diff/160001/tryton/client.py#newcode31 tryton/client.py:31: E402 module level import not at ...
3 weeks, 2 days ago (2018-06-22 13:06:11 UTC) #39
ced
still LGTM
3 weeks, 2 days ago (2018-06-22 14:45:00 UTC) #40
rietveld-bot_tryton.org
6 days, 9 hours ago (2018-07-09 11:10:55 UTC) #41
New changeset 85807558a07e by Nicolas ?vrard in branch 'default':
Validate dictionary items
https://hg.tryton.org/tryton/rev/85807558a07e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69