Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 53321002: account_invoice: Show number and reference in invoice rec_name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by smn
Modified:
2 months ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : account_invoice: Show number and reference in invoice rec_name #

Total comments: 1

Patch Set 3 : account_invoice: Show number and reference in invoice rec_name #

Total comments: 1

Patch Set 4 : account_invoice: Avoid multiple returns, add CHANGELOG #

Patch Set 5 : account_invoice: Fix CHANGELOG order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M invoice.py View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17
smn
4 months, 2 weeks ago (2018-06-30 13:49:24 UTC) #1
reviewbot
https://codereview.tryton.org/53321002/diff/1/invoice.py#newcode648 invoice.py:648: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/53321002
4 months, 2 weeks ago (2018-06-30 14:02:30 UTC) #2
ced
I think the title could be more precise by naming what is "more info". https://codereview.tryton.org/53321002/diff/1/invoice.py ...
4 months, 2 weeks ago (2018-07-02 07:33:49 UTC) #3
pokoli
https://codereview.tryton.org/53321002/diff/1/invoice.py File invoice.py (right): https://codereview.tryton.org/53321002/diff/1/invoice.py#newcode1102 invoice.py:1102: res = [] I will prefer a more meaningfull ...
4 months, 2 weeks ago (2018-07-02 07:41:09 UTC) #4
smn
account_invoice: Show number and reference in invoice rec_name
4 months, 2 weeks ago (2018-07-02 07:42:46 UTC) #5
ced
https://codereview.tryton.org/53321002/diff/20001/invoice.py File invoice.py (right): https://codereview.tryton.org/53321002/diff/20001/invoice.py#newcode1102 invoice.py:1102: rec_name = [] Strange for a list. I would ...
4 months, 2 weeks ago (2018-07-02 07:52:57 UTC) #6
reviewbot
https://codereview.tryton.org/53321002/diff/20001/invoice.py#newcode648 invoice.py:648: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/53321002
4 months, 2 weeks ago (2018-07-02 07:59:49 UTC) #7
smn
account_invoice: Show number and reference in invoice rec_name
4 months, 2 weeks ago (2018-07-02 08:11:09 UTC) #8
reviewbot
https://codereview.tryton.org/53321002/diff/40001/invoice.py#newcode648 invoice.py:648: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/53321002
4 months, 2 weeks ago (2018-07-02 08:31:46 UTC) #9
ced
https://codereview.tryton.org/53321002/diff/40001/invoice.py File invoice.py (right): https://codereview.tryton.org/53321002/diff/40001/invoice.py#newcode1108 invoice.py:1108: return '(%s)' % self.id Why not append to items ...
4 months, 2 weeks ago (2018-07-05 22:50:27 UTC) #10
ced
It misses a CHANGELOG entry.
4 months, 2 weeks ago (2018-07-05 22:50:46 UTC) #11
smn
account_invoice: Avoid multiple returns, add CHANGELOG
4 months, 1 week ago (2018-07-08 06:38:21 UTC) #12
reviewbot
https://codereview.tryton.org/53321002/diff/60001/invoice.py#newcode648 invoice.py:648: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/53321002
4 months, 1 week ago (2018-07-08 06:42:11 UTC) #13
smn
account_invoice: Fix CHANGELOG order
4 months, 1 week ago (2018-07-08 06:46:28 UTC) #14
reviewbot
https://codereview.tryton.org/53321002/diff/80001/invoice.py#newcode648 invoice.py:648: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/53321002
4 months, 1 week ago (2018-07-08 07:15:48 UTC) #15
ced
LGTM
4 months, 1 week ago (2018-07-11 13:37:18 UTC) #16
rietveld-bot_tryton.org
4 months, 1 week ago (2018-07-11 15:17:41 UTC) #17
New changeset 6c4f720747a0 by Sergio Morillo in branch 'default':
Show number and reference in invoice rec_name
https://hg.tryton.org/modules/account_invoice/rev/6c4f720747a0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766