Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(143)

Issue 53491002: stock: Avoid duplicate column names in compute quantity when grouping with existing columns (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by smn
Modified:
3 weeks, 2 days ago
Reviewers:
dave, reviewbot, rietveld-bot, ced, pokoli
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : stock: Fix in default branch #

Total comments: 2

Patch Set 3 : stock: Keep the insert order #

Total comments: 2

Patch Set 4 : stock: Do the opposite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M move.py View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17
smn
1 month, 1 week ago (2018-12-11 12:19:09 UTC) #1
smn
stock: Fix in default branch
1 month, 1 week ago (2018-12-11 12:36:09 UTC) #2
reviewbot
https://codereview.tryton.org/53491002/diff/20001/move.py#newcode1049 move.py:1049: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 1 week ago (2018-12-11 12:47:49 UTC) #3
dave
Hi, I think you need to add the bug tracker issue number to the review ...
1 month, 1 week ago (2018-12-11 14:07:26 UTC) #4
smn
On 2018/12/11 14:07:26, dave wrote: > Hi, > > I think you need to add ...
1 month, 1 week ago (2018-12-11 15:17:01 UTC) #5
ced
https://codereview.tryton.org/53491002/diff/20001/move.py File move.py (right): https://codereview.tryton.org/53491002/diff/20001/move.py#newcode1000 move.py:1000: columns += list(grouping) I would be better to use ...
1 month, 1 week ago (2018-12-11 17:37:13 UTC) #6
smn
stock: Keep the insert order
1 month, 1 week ago (2018-12-16 17:33:32 UTC) #7
reviewbot
https://codereview.tryton.org/53491002/diff/30001/move.py#newcode1053 move.py:1053: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month, 1 week ago (2018-12-16 17:42:53 UTC) #8
pokoli
I think the commit message can be improved by not using "Fix..." but explaining what ...
1 month ago (2018-12-17 18:40:01 UTC) #9
ced
On 2018/12/17 18:40:01, pokoli wrote: > I think the commit message can be improved by ...
1 month ago (2018-12-17 22:39:18 UTC) #10
ced
https://codereview.tryton.org/53491002/diff/30001/move.py File move.py (right): https://codereview.tryton.org/53491002/diff/30001/move.py#newcode1001 move.py:1001: if c not in grouping] + list(grouping) Why not ...
1 month ago (2018-12-17 22:39:22 UTC) #11
smn
stock: Do the opposite
1 month ago (2018-12-18 09:44:57 UTC) #12
smn
https://codereview.tryton.org/53491002/diff/30001/move.py File move.py (right): https://codereview.tryton.org/53491002/diff/30001/move.py#newcode1001 move.py:1001: if c not in grouping] + list(grouping) On 2018/12/17 ...
1 month ago (2018-12-18 09:45:49 UTC) #13
reviewbot
https://codereview.tryton.org/53491002/diff/50001/move.py#newcode1050 move.py:1050: E712 comparison to True should be 'if cond is not True:' or 'if ...
1 month ago (2018-12-18 10:15:59 UTC) #14
ced
LGTM
1 month ago (2018-12-22 17:16:26 UTC) #15
rietveld-bot_tryton.org
New changeset 8795daf34917 by Sergio Morillo in branch 'default': Avoid duplicate column names in compute ...
1 month ago (2018-12-22 17:17:26 UTC) #16
rietveld-bot_tryton.org
3 weeks, 2 days ago (2018-12-30 18:10:22 UTC) #17
New changeset fc0e02c01034 by Sergio Morillo in branch '5.0':
Avoid duplicate column names in compute quantity when grouping with existing
columns
https://hg.tryton.org/modules/stock/rev/fc0e02c01034


New changeset 7e2768b6b943 by Sergio Morillo in branch '4.8':
Avoid duplicate column names in compute quantity when grouping with existing
columns
https://hg.tryton.org/modules/stock/rev/7e2768b6b943
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766