Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 53521002: trytond: Make Cache transactional (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by ced
Modified:
3 days, 15 hours ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

We implement sync, commit and rollback to follow transaction semantic. When a transaction clears a cache, the global cache is cleared only when the transaction is committed meanwhile the transaction will use a cache for itself only. We remove _nocache option because the sync, commit and rollback operate only for the transaction. issue7975

Patch Set 1 #

Patch Set 2 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -95 lines) Patch
M CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M doc/ref/cache.rst View 1 chunk +6 lines, -6 lines 0 comments Download
M trytond/admin.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/cache.py View 5 chunks +76 lines, -59 lines 0 comments Download
M trytond/protocols/dispatcher.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/tests/test_cache.py View 2 chunks +53 lines, -1 line 0 comments Download
M trytond/tests/test_tryton.py View 6 chunks +7 lines, -12 lines 0 comments Download
M trytond/transaction.py View 6 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 6
ced
2 weeks ago (2019-01-07 18:21:54 UTC) #1
reviewbot
https://codereview.tryton.org/53521002/diff/1/trytond/admin.py#newcode46 trytond/admin.py:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
2 weeks ago (2019-01-07 18:36:11 UTC) #2
ced
Update to tip
6 days, 11 hours ago (2019-01-15 14:22:58 UTC) #3
reviewbot
https://codereview.tryton.org/53521002/diff/20001/trytond/admin.py#newcode46 trytond/admin.py:46: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
6 days, 11 hours ago (2019-01-15 14:40:40 UTC) #4
rietveld-bot_tryton.org
New changeset a83631f4ba67 by Cédric Krier in branch 'default': Make Cache transactional https://hg.tryton.org/trytond/rev/a83631f4ba67
3 days, 15 hours ago (2019-01-18 10:57:29 UTC) #5
rietveld-bot_tryton.org
3 days, 15 hours ago (2019-01-18 10:57:36 UTC) #6
New changeset cd5ef07e3c89 by Cédric Krier in branch 'default':
Make Cache transactional
https://hg.tryton.org/tryton-env/rev/cd5ef07e3c89
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766