Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 54351002: tryton: Show ScrolledWindow before setting the states (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by ced
Modified:
1 month, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

This prevent of weird behavior when the ScrolledWindow is the last and only visible Notebook widget. Without this call to show, the page is not visible in the Notebook. issue7698

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tryton/gui/window/view_form/view/form_gtk/state_widget.py View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9
ced
2 months ago (2018-09-13 16:40:05 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54351002
2 months ago (2018-09-13 17:00:26 UTC) #2
pokoli
https://codereview.tryton.org/54351002/diff/1/tryton/gui/window/view_form/view/form_gtk/state_widget.py File tryton/gui/window/view_form/view/form_gtk/state_widget.py (right): https://codereview.tryton.org/54351002/diff/1/tryton/gui/window/view_form/view/form_gtk/state_widget.py#newcode82 tryton/gui/window/view_form/view/form_gtk/state_widget.py:82: # Force to show first to ensure it is ...
1 month, 4 weeks ago (2018-09-19 15:03:46 UTC) #3
ced
Fix typo
1 month, 4 weeks ago (2018-09-19 15:23:39 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/54351002
1 month, 4 weeks ago (2018-09-19 15:30:07 UTC) #5
pokoli
LGTM
1 month, 3 weeks ago (2018-09-21 08:53:02 UTC) #6
rietveld-bot_tryton.org
New changeset 227ce45920ca by Cédric Krier in branch 'default': Show ScrolledWindow before setting the states ...
1 month, 3 weeks ago (2018-09-24 12:26:53 UTC) #7
rietveld-bot_tryton.org
New changeset 28939071eb14 by Cédric Krier in branch 'default': Show ScrolledWindow before setting the states ...
1 month, 3 weeks ago (2018-09-24 12:26:55 UTC) #8
rietveld-bot_tryton.org
1 month, 2 weeks ago (2018-10-02 11:08:59 UTC) #9
New changeset 1743b2861ab3 by Cédric Krier in branch '4.8':
Show ScrolledWindow before setting the states
https://hg.tryton.org/tryton/rev/1743b2861ab3


New changeset 1254fa9e5ee5 by Cédric Krier in branch '4.6':
Show ScrolledWindow before setting the states
https://hg.tryton.org/tryton/rev/1254fa9e5ee5


New changeset 91a75ec0022d by Cédric Krier in branch '4.4':
Show ScrolledWindow before setting the states
https://hg.tryton.org/tryton/rev/91a75ec0022d


New changeset 518750311d34 by Cédric Krier in branch '4.2':
Show ScrolledWindow before setting the states
https://hg.tryton.org/tryton/rev/518750311d34


New changeset 230095f299a2 by Cédric Krier in branch '4.0':
Show ScrolledWindow before setting the states
https://hg.tryton.org/tryton/rev/230095f299a2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766