Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 54351002: tryton: Show ScrolledWindow before setting the states

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by ced
Modified:
22 hours, 42 minutes ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

This prevent of weird behavior when the ScrolledWindow is the last and only visible Notebook widget. Without this call to show, the page is not visible in the Notebook. issue7698

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tryton/gui/window/view_form/view/form_gtk/state_widget.py View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6
ced
1 week, 1 day ago (2018-09-13 16:40:05 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54351002
1 week, 1 day ago (2018-09-13 17:00:26 UTC) #2
pokoli
https://codereview.tryton.org/54351002/diff/1/tryton/gui/window/view_form/view/form_gtk/state_widget.py File tryton/gui/window/view_form/view/form_gtk/state_widget.py (right): https://codereview.tryton.org/54351002/diff/1/tryton/gui/window/view_form/view/form_gtk/state_widget.py#newcode82 tryton/gui/window/view_form/view/form_gtk/state_widget.py:82: # Force to show first to ensure it is ...
2 days, 16 hours ago (2018-09-19 15:03:46 UTC) #3
ced
Fix typo
2 days, 16 hours ago (2018-09-19 15:23:39 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/54351002
2 days, 16 hours ago (2018-09-19 15:30:07 UTC) #5
pokoli
22 hours, 42 minutes ago (2018-09-21 08:53:02 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766