Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(867)

Issue 54401002: tryton: Wait to be sure about the scheme before construct the bus URL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by ced
Modified:
6 months, 3 weeks ago
Reviewers:
bch, pokoli, yangoon, rietveld-bot, nicoe
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Explicit return None #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tryton/bus.py View 2 chunks +6 lines, -1 line 0 comments Download
M tryton/jsonrpc.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
ced
7 months, 1 week ago (2018-10-17 22:08:55 UTC) #1
pokoli
LGTM
7 months ago (2018-10-18 07:30:48 UTC) #2
nicoe
https://codereview.tryton.org/54401002/diff/1/tryton/jsonrpc.py File tryton/jsonrpc.py (right): https://codereview.tryton.org/54401002/diff/1/tryton/jsonrpc.py#newcode343 tryton/jsonrpc.py:343: return Why do you remove False ? https://codereview.tryton.org/54401002/diff/1/tryton/jsonrpc.py#newcode348 tryton/jsonrpc.py:348: ...
7 months ago (2018-10-18 16:27:42 UTC) #3
ced
Explicit return None
7 months ago (2018-10-18 16:31:27 UTC) #4
ced
https://codereview.tryton.org/54401002/diff/1/tryton/jsonrpc.py File tryton/jsonrpc.py (right): https://codereview.tryton.org/54401002/diff/1/tryton/jsonrpc.py#newcode343 tryton/jsonrpc.py:343: return On 2018/10/18 16:27:42, nicoe wrote: > Why do ...
7 months ago (2018-10-18 16:31:31 UTC) #5
rietveld-bot_tryton.org
New changeset 410709f6270b by Cédric Krier in branch 'default': Wait to be sure about the ...
6 months, 3 weeks ago (2018-10-31 07:39:34 UTC) #6
rietveld-bot_tryton.org
6 months, 3 weeks ago (2018-10-31 07:39:44 UTC) #7
New changeset c8cb5d7608d1 by Cédric Krier in branch 'default':
Wait to be sure about the scheme before construct the bus URL
https://hg.tryton.org/tryton-env/rev/c8cb5d7608d1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766