Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 54421002: trytond: Remove implicit fields names in ModelStorage.read (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by ced
Modified:
4 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

It is a bad practice to not explicit the fields to read. So we should not support it. issue7830

Patch Set 1 #

Patch Set 2 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -46 lines) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M doc/ref/models/models.rst View 1 chunk +4 lines, -3 lines 0 comments Download
M trytond/ir/lang.py View 1 chunk +3 lines, -3 lines 0 comments Download
M trytond/ir/model.py View 2 chunks +2 lines, -5 lines 0 comments Download
M trytond/ir/resource.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/model/modelsingleton.py View 2 chunks +2 lines, -5 lines 0 comments Download
M trytond/model/modelsql.py View 1 1 chunk +1 line, -8 lines 0 comments Download
M trytond/model/modelstorage.py View 1 1 chunk +1 line, -10 lines 0 comments Download
M trytond/res/user.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/tests/test_access.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/tests/test_history.py View 3 chunks +3 lines, -3 lines 0 comments Download
M trytond/tests/test_rule.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7
ced
5 months, 2 weeks ago (2018-11-01 17:49:06 UTC) #1
reviewbot
https://codereview.tryton.org/54421002/diff/1/trytond/model/modelsingleton.py#newcode110 trytond/model/modelsingleton.py:110: E501 line too long (84 > 79 characters) https://codereview.tryton.org/54421002/diff/1/trytond/model/modelsql.py#newcode356 trytond/model/modelsql.py:356: E127 continuation line ...
5 months, 2 weeks ago (2018-11-01 17:53:37 UTC) #2
pokoli
LGTM
5 months, 2 weeks ago (2018-11-02 15:19:43 UTC) #3
ced
Update to tip
5 months ago (2018-11-18 16:22:38 UTC) #4
reviewbot
https://codereview.tryton.org/54421002/diff/20001/trytond/model/modelsingleton.py#newcode110 trytond/model/modelsingleton.py:110: E501 line too long (84 > 79 characters) https://codereview.tryton.org/54421002/diff/20001/trytond/model/modelsql.py#newcode355 trytond/model/modelsql.py:355: E127 continuation line ...
5 months ago (2018-11-18 16:37:43 UTC) #5
rietveld-bot_tryton.org
New changeset bfef7a2472b2 by Cédric Krier in branch 'default': Remove implicit fields names in ModelStorage.read ...
4 months, 3 weeks ago (2018-11-28 09:05:13 UTC) #6
rietveld-bot_tryton.org
4 months, 3 weeks ago (2018-11-28 09:05:21 UTC) #7
New changeset df770d5f4138 by Cédric Krier in branch 'default':
Remove implicit fields names in ModelStorage.read
https://hg.tryton.org/tryton-env/rev/df770d5f4138
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766