Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 54441002: account: Add active on tax template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by ced
Modified:
1 day, 4 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

With the ondelete RESTRICT, this will allow to deactivate the taxes, which were removed from the template, when the chart of account is updated. issue7718

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M tax.py View 3 chunks +4 lines, -3 lines 0 comments Download
M view/tax_template_form.xml View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 7
ced
3 weeks, 2 days ago (2018-11-25 13:26:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54441002
3 weeks, 2 days ago (2018-11-25 13:47:51 UTC) #2
pokoli
https://codereview.tryton.org/54441002/diff/1/view/tax_template_form.xml File view/tax_template_form.xml (right): https://codereview.tryton.org/54441002/diff/1/view/tax_template_form.xml#newcode12 view/tax_template_form.xml:12: <field name="account"/> won't be better to include a single ...
2 weeks ago (2018-12-04 11:31:32 UTC) #3
ced
https://codereview.tryton.org/54441002/diff/1/view/tax_template_form.xml File view/tax_template_form.xml (right): https://codereview.tryton.org/54441002/diff/1/view/tax_template_form.xml#newcode12 view/tax_template_form.xml:12: <field name="account"/> On 2018/12/04 11:31:31, pokoli wrote: > won't ...
2 weeks ago (2018-12-04 11:47:20 UTC) #4
pokoli
LGTM
2 weeks ago (2018-12-04 12:16:21 UTC) #5
rietveld-bot_tryton.org
New changeset 89e7d17d4865 by Cédric Krier in branch 'default': Add active on tax template https://hg.tryton.org/modules/account/rev/89e7d17d4865
1 day, 4 hours ago (2018-12-17 22:05:26 UTC) #6
rietveld-bot_tryton.org
1 day, 4 hours ago (2018-12-17 22:05:32 UTC) #7
New changeset d796a7159ebd by Cédric Krier in branch 'default':
Add active on tax template
https://hg.tryton.org/tryton-env/rev/d796a7159ebd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766