Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 54471002: tryton: Replace value attribute of HTTPStatus by int call (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ced
Modified:
2 months, 1 week ago
Reviewers:
rietveld-bot, lukio, reviewbot
Visibility:
Public.

Description

In Python3.4, HTTPStatus are not yet enums but just integers. issue7945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tryton/common/common.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
ced
3 months ago (2018-12-24 15:33:07 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54471002
3 months ago (2018-12-24 15:38:05 UTC) #2
rietveld-bot_tryton.org
New changeset efa98c168ea0 by Cédric Krier in branch 'default': Replace value attribute of HTTPStatus by ...
2 months, 3 weeks ago (2019-01-02 18:01:23 UTC) #3
rietveld-bot_tryton.org
New changeset e5b5fb418fcb by Cédric Krier in branch 'default': Replace value attribute of HTTPStatus by ...
2 months, 3 weeks ago (2019-01-02 18:01:25 UTC) #4
lukio
Applied this patch and it works at 5.0 branches. LGTM
2 months, 2 weeks ago (2019-01-06 20:48:01 UTC) #5
rietveld-bot_tryton.org
2 months, 1 week ago (2019-01-14 18:03:03 UTC) #6
New changeset 2ad6a6c0f692 by Cédric Krier in branch '5.0':
Replace value attribute of HTTPStatus by int call
https://hg.tryton.org/tryton/rev/2ad6a6c0f692
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766