Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(861)

Issue 54481002: tryton-env: Add HTML editor

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by ced
Modified:
1 week ago
Reviewers:
pokoli, reviewbot, dave
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix message, allow custom title and encode params #

Patch Set 3 : Add body class #

Total comments: 5

Patch Set 4 : Fix remarks #

Patch Set 5 : Update to tip #

Patch Set 6 : flake8 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -49 lines) Patch
M sao/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/view/form.js View 1 2 3 4 4 chunks +65 lines, -1 line 2 comments Download
M tryton/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form.py View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/url.py View 1 2 3 4 5 2 chunks +56 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/widget.py View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/topics/configuration.rst View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M trytond/trytond/ir/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download
A trytond/trytond/ir/routes.py View 1 2 1 chunk +154 lines, -0 lines 0 comments Download
M trytond/trytond/ir/ui/form.rnc View 1 chunk +24 lines, -23 lines 0 comments Download
M trytond/trytond/ir/ui/form.rng View 1 2 3 4 1 chunk +21 lines, -20 lines 0 comments Download
M trytond/trytond/protocols/wrappers.py View 1 2 3 4 2 chunks +10 lines, -3 lines 0 comments Download
M trytond/trytond/wsgi.py View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16
ced
1 month ago (2019-01-16 17:33:38 UTC) #1
reviewbot
https://codereview.tryton.org/54481002/diff/1/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/1/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
1 month ago (2019-01-16 17:46:24 UTC) #2
pokoli
https://codereview.tryton.org/54481002/diff/1/trytond/trytond/ir/message.xml File trytond/trytond/ir/message.xml (right): https://codereview.tryton.org/54481002/diff/1/trytond/trytond/ir/message.xml#newcode185 trytond/trytond/ir/message.xml:185: <field name="text">Fail to save, please retry.</field> Fail to save ...
1 month ago (2019-01-16 17:52:34 UTC) #3
ced
1 month ago (2019-01-16 22:32:44 UTC) #4
reviewbot
https://codereview.tryton.org/54481002/diff/20001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/20001/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
1 month ago (2019-01-16 22:41:45 UTC) #5
ced
1 month ago (2019-01-17 10:41:16 UTC) #6
reviewbot
https://codereview.tryton.org/54481002/diff/40001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/40001/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
1 month ago (2019-01-17 11:18:48 UTC) #7
dave
https://codereview.tryton.org/54481002/diff/40001/trytond/doc/topics/configuration.rst File trytond/doc/topics/configuration.rst (right): https://codereview.tryton.org/54481002/diff/40001/trytond/doc/topics/configuration.rst#newcode421 trytond/doc/topics/configuration.rst:421: The space list of TinyMCE plugins to load. Perhaps: ...
4 weeks, 1 day ago (2019-01-18 11:10:41 UTC) #8
ced
4 weeks, 1 day ago (2019-01-18 11:56:49 UTC) #9
reviewbot
https://codereview.tryton.org/54481002/diff/60001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/60001/trytond/trytond/wsgi.py#newcode185 trytond/trytond/wsgi.py:185: F401 'trytond' imported ...
4 weeks, 1 day ago (2019-01-18 12:09:46 UTC) #10
ced
1 week ago (2019-02-09 00:49:32 UTC) #11
reviewbot
https://codereview.tryton.org/54481002/diff/80001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode151 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:151: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/80001/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported ...
1 week ago (2019-02-09 01:13:14 UTC) #12
ced
1 week ago (2019-02-09 09:27:03 UTC) #13
reviewbot
https://codereview.tryton.org/54481002/diff/100001/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/100001/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
1 week ago (2019-02-09 09:42:31 UTC) #14
pokoli
https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js File sao/src/view/form.js (right): https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js#newcode3970 sao/src/view/form.js:3970: if (!record || (record.id < 0)) { I think ...
1 week ago (2019-02-09 18:16:22 UTC) #15
ced
1 week ago (2019-02-09 18:23:02 UTC) #16
https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js
File sao/src/view/form.js (right):

https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js#newco...
sao/src/view/form.js:3970: if (!record || (record.id < 0)) {
On 2019/02/09 18:16:22, pokoli wrote:
> I think we should show an error message explaining that the record must be
> sabved in order to edit the html widget (as we do with translations)

A link without href appears as disabled and can not be clicked. For me, it is
enough and even better than error message.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766