Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 54481002: tryton-env: Add HTML editor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ced
Modified:
2 weeks, 5 days ago
Reviewers:
pokoli, reviewbot, rietveld-bot, dave
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix message, allow custom title and encode params #

Patch Set 3 : Add body class #

Total comments: 5

Patch Set 4 : Fix remarks #

Patch Set 5 : Update to tip #

Patch Set 6 : flake8 #

Total comments: 2

Patch Set 7 : Update to tip #

Patch Set 8 : Update to tip #

Patch Set 9 : Allow to customize plugins #

Patch Set 10 : Allow to edit HTML reports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -50 lines) Patch
M sao/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M sao/src/view/form.js View 1 2 3 4 5 6 4 chunks +63 lines, -1 line 0 comments Download
M tryton/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form.py View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/url.py View 1 2 3 4 5 6 7 2 chunks +55 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/form_gtk/widget.py View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/topics/configuration.rst View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -0 lines 0 comments Download
M trytond/trytond/ir/__init__.py View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/trytond/ir/action.py View 1 2 3 4 5 6 7 8 9 4 chunks +22 lines, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
A trytond/trytond/ir/routes.py View 1 2 3 4 5 6 7 8 9 1 chunk +156 lines, -0 lines 0 comments Download
M trytond/trytond/ir/ui/form.rnc View 1 chunk +24 lines, -23 lines 0 comments Download
M trytond/trytond/ir/ui/form.rng View 1 2 3 4 1 chunk +21 lines, -20 lines 0 comments Download
M trytond/trytond/ir/view/action_report_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -1 line 0 comments Download
M trytond/trytond/protocols/wrappers.py View 1 2 3 4 2 chunks +10 lines, -3 lines 0 comments Download
M trytond/trytond/wsgi.py View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 28
ced
3 months ago (2019-01-16 17:33:38 UTC) #1
reviewbot
https://codereview.tryton.org/54481002/diff/1/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/1/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
3 months ago (2019-01-16 17:46:24 UTC) #2
pokoli
https://codereview.tryton.org/54481002/diff/1/trytond/trytond/ir/message.xml File trytond/trytond/ir/message.xml (right): https://codereview.tryton.org/54481002/diff/1/trytond/trytond/ir/message.xml#newcode185 trytond/trytond/ir/message.xml:185: <field name="text">Fail to save, please retry.</field> Fail to save ...
3 months ago (2019-01-16 17:52:34 UTC) #3
ced
3 months ago (2019-01-16 22:32:44 UTC) #4
reviewbot
https://codereview.tryton.org/54481002/diff/20001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/20001/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
3 months ago (2019-01-16 22:41:45 UTC) #5
ced
3 months ago (2019-01-17 10:41:16 UTC) #6
reviewbot
https://codereview.tryton.org/54481002/diff/40001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/40001/trytond/trytond/wsgi.py#newcode158 trytond/trytond/wsgi.py:158: F401 'trytond' imported ...
3 months ago (2019-01-17 11:18:48 UTC) #7
dave
https://codereview.tryton.org/54481002/diff/40001/trytond/doc/topics/configuration.rst File trytond/doc/topics/configuration.rst (right): https://codereview.tryton.org/54481002/diff/40001/trytond/doc/topics/configuration.rst#newcode421 trytond/doc/topics/configuration.rst:421: The space list of TinyMCE plugins to load. Perhaps: ...
3 months ago (2019-01-18 11:10:41 UTC) #8
ced
3 months ago (2019-01-18 11:56:49 UTC) #9
reviewbot
https://codereview.tryton.org/54481002/diff/60001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode150 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:150: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/60001/trytond/trytond/wsgi.py#newcode185 trytond/trytond/wsgi.py:185: F401 'trytond' imported ...
3 months ago (2019-01-18 12:09:46 UTC) #10
ced
2 months, 1 week ago (2019-02-09 00:49:32 UTC) #11
reviewbot
https://codereview.tryton.org/54481002/diff/80001/tryton/tryton/gui/window/view_form/view/form_gtk/url.py#newcode151 tryton/tryton/gui/window/view_form/view/form_gtk/url.py:151: E501 line too long (85 > 79 characters) https://codereview.tryton.org/54481002/diff/80001/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported ...
2 months, 1 week ago (2019-02-09 01:13:14 UTC) #12
ced
2 months, 1 week ago (2019-02-09 09:27:03 UTC) #13
reviewbot
https://codereview.tryton.org/54481002/diff/100001/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/100001/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
2 months, 1 week ago (2019-02-09 09:42:31 UTC) #14
pokoli
https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js File sao/src/view/form.js (right): https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js#newcode3970 sao/src/view/form.js:3970: if (!record || (record.id < 0)) { I think ...
2 months, 1 week ago (2019-02-09 18:16:22 UTC) #15
ced
https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js File sao/src/view/form.js (right): https://codereview.tryton.org/54481002/diff/100001/sao/src/view/form.js#newcode3970 sao/src/view/form.js:3970: if (!record || (record.id < 0)) { On 2019/02/09 ...
2 months, 1 week ago (2019-02-09 18:23:02 UTC) #16
ced
1 month ago (2019-03-17 13:00:20 UTC) #17
reviewbot
https://codereview.tryton.org/54481002/diff/267091002/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/267091002/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
1 month ago (2019-03-17 13:14:17 UTC) #18
ced
3 weeks, 4 days ago (2019-03-24 17:14:42 UTC) #19
reviewbot
https://codereview.tryton.org/54481002/diff/259241002/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/259241002/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
3 weeks, 4 days ago (2019-03-24 17:21:15 UTC) #20
ced
3 weeks, 4 days ago (2019-03-24 17:37:44 UTC) #21
reviewbot
https://codereview.tryton.org/54481002/diff/273181002/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/273181002/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
3 weeks, 4 days ago (2019-03-24 17:48:16 UTC) #22
ced
3 weeks, 4 days ago (2019-03-24 18:21:03 UTC) #23
reviewbot
https://codereview.tryton.org/54481002/diff/273181003/trytond/trytond/wsgi.py#newcode188 trytond/trytond/wsgi.py:188: F401 'trytond' imported but unused https://codereview.tryton.org/54481002/diff/273181003/trytond/trytond/wsgi.py#newcode187 trytond/trytond/wsgi.py:187: E402 module level import not at ...
3 weeks, 4 days ago (2019-03-24 18:45:10 UTC) #24
rietveld-bot_tryton.org
New changeset 25ba98274e26 by Cédric Krier in branch 'default': Add HTML editor https://hg.tryton.org/sao/rev/25ba98274e26
2 weeks, 5 days ago (2019-03-30 15:05:00 UTC) #25
rietveld-bot_tryton.org
New changeset baf8965e135f by Cédric Krier in branch 'default': Add HTML editor https://hg.tryton.org/tryton/rev/baf8965e135f
2 weeks, 5 days ago (2019-03-30 15:05:04 UTC) #26
rietveld-bot_tryton.org
New changeset 0c6cf104c008 by Cédric Krier in branch 'default': Add HTML editor https://hg.tryton.org/trytond/rev/0c6cf104c008
2 weeks, 5 days ago (2019-03-30 15:05:05 UTC) #27
rietveld-bot_tryton.org
2 weeks, 5 days ago (2019-03-30 15:05:10 UTC) #28
New changeset d92f130b40a0 by Cédric Krier in branch 'default':
Add HTML editor
https://hg.tryton.org/tryton-env/rev/d92f130b40a0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766