Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(799)

Issue 54521002: tryton-env: Cast timestamp string to datetime in Cache.commit when using sqlite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by nicoe
Modified:
3 days, 10 hours ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

tryton-env: Cast timestamp string to datetime in Cache.commit when using sqlite issue8080

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M trytond/trytond/cache.py View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 3
nicoe
1 week, 3 days ago (2019-02-06 15:26:27 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54521002
1 week, 3 days ago (2019-02-06 15:44:17 UTC) #2
pokoli
1 week, 3 days ago (2019-02-06 15:47:48 UTC) #3
https://codereview.tryton.org/54521002/diff/1/trytond/trytond/cache.py
File trytond/trytond/cache.py (right):

https://codereview.tryton.org/54521002/diff/1/trytond/trytond/cache.py#newcod...
trytond/trytond/cache.py:166: if backend.name() == 'sqlite':
why not using

 if not isinstance(timestamp, str): 

Which will always work despite of the backend name. 

We use this pattern on other queries, for example: 

http://hg.tryton.org/modules/account/file/d50e0560d168/account.py#l789
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766