Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2139)

Issue 54541002: tryton: Do not use set_text of Many2One and Reference when setting only string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by ced
Modified:
2 months, 2 weeks ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

changeset 13d81b52b4c4 replaced some direct call to wid_text.set_text by the set_text but it set_text on Reference expect to receive a tuple (from get_client). So when set_text is called just to clear or update the wid_text it loose the selection of Reference. Indeed as most of the time, it is called with an empty string, there is no need to set the position of the entry. issue8114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tryton/gui/window/view_form/view/form_gtk/many2one.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/reference.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ced
3 months, 1 week ago (2019-02-14 11:52:33 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54541002
3 months, 1 week ago (2019-02-14 12:07:47 UTC) #2
rietveld-bot_tryton.org
New changeset 463422070600 by Cédric Krier in branch 'default': Do not use set_text of Many2One ...
2 months, 3 weeks ago (2019-02-26 14:41:20 UTC) #3
rietveld-bot_tryton.org
New changeset 8d262e544d6c by Cédric Krier in branch 'default': Do not use set_text of Many2One ...
2 months, 3 weeks ago (2019-02-26 14:41:21 UTC) #4
rietveld-bot_tryton.org
2 months, 2 weeks ago (2019-03-06 23:06:48 UTC) #5
New changeset 437dfe7a9af0 by Cédric Krier in branch '5.0':
Do not use set_text of Many2One and Reference when setting only string
https://hg.tryton.org/tryton/rev/437dfe7a9af0


New changeset 1e1f7aa43c12 by Cédric Krier in branch '4.8':
Do not use set_text of Many2One and Reference when setting only string
https://hg.tryton.org/tryton/rev/1e1f7aa43c12


New changeset 374af4a3d358 by Cédric Krier in branch '4.6':
Do not use set_text of Many2One and Reference when setting only string
https://hg.tryton.org/tryton/rev/374af4a3d358


New changeset c73ce3f572ca by Cédric Krier in branch '4.4':
Do not use set_text of Many2One and Reference when setting only string
https://hg.tryton.org/tryton/rev/c73ce3f572ca


New changeset 541f901987eb by Cédric Krier in branch '4.2':
Do not use set_text of Many2One and Reference when setting only string
https://hg.tryton.org/tryton/rev/541f901987eb
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766