Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 54551002: account: Do not recreate models that have template override is True (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 4 weeks ago by ced
Modified:
1 month ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The dictionary template2*** must always be filled even if template override is True because create_*** calls will use this dictionary to not recreate the records. issue7938

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use right model in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -66 lines) Patch
M account.py View 2 chunks +20 lines, -18 lines 0 comments Download
M tax.py View 3 chunks +43 lines, -40 lines 0 comments Download
M tests/test_account.py View 1 3 chunks +106 lines, -8 lines 0 comments Download

Messages

Total messages: 9
ced
1 month, 4 weeks ago (2019-02-19 11:15:47 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/54551002
1 month, 4 weeks ago (2019-02-19 11:16:22 UTC) #2
pokoli
https://codereview.tryton.org/54551002/diff/1/account.py File account.py (right): https://codereview.tryton.org/54551002/diff/1/account.py#newcode288 account.py:288: template2type[child.template.id] = child.id Do you think moving this line ...
1 month, 2 weeks ago (2019-03-01 15:30:20 UTC) #3
ced
https://codereview.tryton.org/54551002/diff/1/account.py File account.py (right): https://codereview.tryton.org/54551002/diff/1/account.py#newcode288 account.py:288: template2type[child.template.id] = child.id On 2019/03/01 15:30:19, pokoli wrote: > ...
1 month, 2 weeks ago (2019-03-01 15:51:12 UTC) #4
ced
Use right model in test
1 month, 2 weeks ago (2019-03-01 15:52:25 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/54551002
1 month, 2 weeks ago (2019-03-01 16:14:44 UTC) #6
rietveld-bot_tryton.org
New changeset 10df9d79188c by Cédric Krier in branch 'default': Do not recreate models that have ...
1 month, 1 week ago (2019-03-08 17:49:43 UTC) #7
rietveld-bot_tryton.org
New changeset 71234def8714 by Cédric Krier in branch 'default': Do not recreate models that have ...
1 month, 1 week ago (2019-03-08 17:49:51 UTC) #8
rietveld-bot_tryton.org
1 month ago (2019-03-16 22:21:17 UTC) #9
New changeset d48a794599b1 by Cédric Krier in branch '5.0':
Do not recreate models that have template override is True
https://hg.tryton.org/modules/account/rev/d48a794599b1


New changeset b812aae86970 by Cédric Krier in branch '4.8':
Do not recreate models that have template override is True
https://hg.tryton.org/modules/account/rev/b812aae86970
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766