Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 56381002: tryton-env: Allow to pass parent_context when calling get_context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by ced
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename parent_context into record_context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M sao/src/model.js View 1 4 chunks +15 lines, -8 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/field.py View 3 chunks +10 lines, -6 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/group.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10
ced
2 months ago (2018-09-13 16:24:48 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/56381002
2 months ago (2018-09-13 16:38:32 UTC) #2
pokoli
https://codereview.tryton.org/56381002/diff/1/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/56381002/diff/1/tryton/tryton/gui/window/view_form/model/field.py#newcode63 tryton/tryton/gui/window/view_form/model/field.py:63: def get_context(self, record, record_context=None): why naming it record_context on ...
2 months ago (2018-09-18 14:06:48 UTC) #3
ced
https://codereview.tryton.org/56381002/diff/1/tryton/tryton/gui/window/view_form/model/field.py File tryton/tryton/gui/window/view_form/model/field.py (right): https://codereview.tryton.org/56381002/diff/1/tryton/tryton/gui/window/view_form/model/field.py#newcode63 tryton/tryton/gui/window/view_form/model/field.py:63: def get_context(self, record, record_context=None): On 2018/09/18 14:06:48, pokoli wrote: ...
2 months ago (2018-09-18 14:55:43 UTC) #4
ced
2 months ago (2018-09-18 14:55:56 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/56381002
2 months ago (2018-09-18 15:32:11 UTC) #6
pokoli
LGTM
1 month, 4 weeks ago (2018-09-19 13:38:11 UTC) #7
rietveld-bot_tryton.org
New changeset 187247b46550 by Cédric Krier in branch 'default': Allow to pass parent_context when calling ...
1 month, 3 weeks ago (2018-09-21 09:02:30 UTC) #8
rietveld-bot_tryton.org
New changeset 6cf5ac95b1b6 by Cédric Krier in branch 'default': Allow to pass parent_context when calling ...
1 month, 3 weeks ago (2018-09-21 09:02:34 UTC) #9
rietveld-bot_tryton.org
1 month, 3 weeks ago (2018-09-21 09:02:36 UTC) #10
New changeset ae25ecfb66de by Cédric Krier in branch 'default':
Allow to pass parent_context when calling get_context
https://hg.tryton.org/tryton-env/rev/ae25ecfb66de
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766