Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 56471002: company: Use company country code for as phone country code when empty (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by pokoli
Modified:
5 days, 8 hours ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Return a list of company country codes #

Patch Set 3 : Use generator #

Patch Set 4 : remove _get from method name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M __init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M party.py View 1 2 3 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 9
pokoli
1 month, 1 week ago (2018-11-10 16:13:25 UTC) #1
reviewbot
https://codereview.tryton.org/56471002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56471002/diff/1/__init__.py#newcode6 __init__.py:6: ...
1 month, 1 week ago (2018-11-10 16:43:12 UTC) #2
pokoli
Return a list of company country codes
2 weeks ago (2018-12-04 11:14:35 UTC) #3
reviewbot
https://codereview.tryton.org/56471002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56471002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
2 weeks ago (2018-12-04 11:37:40 UTC) #4
pokoli
Use generator
1 week, 6 days ago (2018-12-05 09:12:27 UTC) #5
reviewbot
https://codereview.tryton.org/56471002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56471002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
1 week, 6 days ago (2018-12-05 09:34:36 UTC) #6
pokoli
remove _get from method name
1 week, 6 days ago (2018-12-05 12:13:09 UTC) #7
reviewbot
https://codereview.tryton.org/56471002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56471002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
1 week, 6 days ago (2018-12-05 12:16:07 UTC) #8
rietveld-bot_tryton.org
5 days, 8 hours ago (2018-12-13 17:51:53 UTC) #9
New changeset bf0e85514a98 by Sergi Almacellas Abellana in branch 'default':
Use company country code for phone country code
https://hg.tryton.org/modules/company/rev/bf0e85514a98
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766