Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 56481002: tryton-env: Add Array field

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by pokoli
Modified:
2 months, 3 weeks ago
Reviewers:
dave, reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove unrelated code #

Total comments: 7

Patch Set 3 : Use typed arrays #

Total comments: 1

Patch Set 4 : Validate types for sqlite #

Patch Set 5 : Improve docstring #

Total comments: 6

Patch Set 6 : Ensure arrays are not used on views and fix sao super calls #

Patch Set 7 : Use modelstorage.validate and update to tip #

Total comments: 6

Patch Set 8 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -0 lines) Patch
M sao/src/model.js View 1 2 3 4 5 2 chunks +17 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/models/fields.rst View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/trytond/model/fields/__init__.py View 3 1 chunk +1 line, -0 lines 0 comments Download
A trytond/trytond/model/fields/array_.py View 1 2 3 4 5 6 1 chunk +50 lines, -0 lines 0 comments Download
M trytond/trytond/model/modelstorage.py View 1 2 3 4 5 6 7 2 chunks +25 lines, -0 lines 0 comments Download
M trytond/trytond/tests/__init__.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A trytond/trytond/tests/field_array.py View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A trytond/trytond/tests/test_field_array.py View 1 2 3 4 5 6 1 chunk +106 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_tryton.py View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 28
pokoli
5 months, 1 week ago (2018-11-11 20:37:10 UTC) #1
reviewbot
https://codereview.tryton.org/56481002/diff/1/modules/company/__init__.py#newcode5 modules/company/__init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/1/modules/company/__init__.py#newcode6 modules/company/__init__.py:6: ...
5 months, 1 week ago (2018-11-11 20:41:53 UTC) #2
albert
https://codereview.tryton.org/56481002/diff/1/modules/account_invoice/tests/test_account_invoice.py File modules/account_invoice/tests/test_account_invoice.py (right): https://codereview.tryton.org/56481002/diff/1/modules/account_invoice/tests/test_account_invoice.py#newcode210 modules/account_invoice/tests/test_account_invoice.py:210: @with_transaction() This should not be part of this review ...
5 months, 1 week ago (2018-11-11 21:26:03 UTC) #3
pokoli
Remove unrelated code
5 months, 1 week ago (2018-11-11 21:59:55 UTC) #4
reviewbot
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
5 months, 1 week ago (2018-11-11 22:10:24 UTC) #5
ced
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode13 trytond/trytond/model/fields/array_.py:13: _sql_type = 'TEXT' For me, we should use SQL ...
5 months ago (2018-11-19 20:52:42 UTC) #6
pokoli
Use typed arrays
4 months, 4 weeks ago (2018-11-21 11:12:46 UTC) #7
pokoli
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode13 trytond/trytond/model/fields/array_.py:13: _sql_type = 'TEXT' On 2018/11/19 20:52:41, ced wrote: > ...
4 months, 4 weeks ago (2018-11-21 11:12:51 UTC) #8
reviewbot
patch is not applicable URL: https://codereview.tryton.org/56481002
4 months, 4 weeks ago (2018-11-21 11:43:22 UTC) #9
dave
https://codereview.tryton.org/56481002/diff/40001/trytond/model/fields/array_.py File trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/40001/trytond/model/fields/array_.py#newcode11 trytond/model/fields/array_.py:11: 'Define array field.' What about: ''' Define an array ...
4 months, 4 weeks ago (2018-11-21 14:43:35 UTC) #10
ced
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode21 trytond/trytond/model/fields/array_.py:21: loading) On 2018/11/21 11:12:51, pokoli wrote: > On 2018/11/19 ...
4 months, 3 weeks ago (2018-11-27 15:26:13 UTC) #11
pokoli
Validate types for sqlite
4 months, 2 weeks ago (2018-12-04 12:13:41 UTC) #12
pokoli
Improve docstring
4 months, 2 weeks ago (2018-12-04 12:15:43 UTC) #13
reviewbot
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
4 months, 2 weeks ago (2018-12-04 12:44:58 UTC) #14
ced
I think the type should be added for Model.fields_get If we want to have one ...
4 months ago (2018-12-17 22:35:29 UTC) #15
ced
On 2018/12/17 22:35:29, ced wrote: > I think the type should be added for Model.fields_get ...
4 months ago (2018-12-17 22:36:15 UTC) #16
pokoli
Ensure arrays are not used on views and fix sao super calls
3 months, 2 weeks ago (2018-12-30 12:35:05 UTC) #17
pokoli
On 2018/12/17 22:36:15, ced wrote: > On 2018/12/17 22:35:29, ced wrote: > > I think ...
3 months, 2 weeks ago (2018-12-30 12:45:06 UTC) #18
reviewbot
https://codereview.tryton.org/56481002/diff/100001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/100001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
3 months, 2 weeks ago (2018-12-30 12:47:05 UTC) #19
ced
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py#newcode49 trytond/trytond/model/fields/array_.py:49: value = [f.sql_format(v) for v in value] On 2018/12/30 ...
3 months, 2 weeks ago (2018-12-30 12:51:20 UTC) #20
pokoli
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py#newcode49 trytond/trytond/model/fields/array_.py:49: value = [f.sql_format(v) for v in value] On 2018/12/30 ...
3 months, 2 weeks ago (2019-01-02 10:19:35 UTC) #21
ced
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py#newcode49 trytond/trytond/model/fields/array_.py:49: value = [f.sql_format(v) for v in value] On 2019/01/02 ...
3 months, 2 weeks ago (2019-01-02 10:38:12 UTC) #22
pokoli
Use modelstorage.validate and update to tip
3 months, 2 weeks ago (2019-01-03 10:47:52 UTC) #23
pokoli
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/model/fields/array_.py#newcode49 trytond/trytond/model/fields/array_.py:49: value = [f.sql_format(v) for v in value] On 2019/01/02 ...
3 months, 2 weeks ago (2019-01-03 10:48:53 UTC) #24
reviewbot
https://codereview.tryton.org/56481002/diff/120001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/120001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
3 months, 2 weeks ago (2019-01-03 11:09:42 UTC) #25
ced
https://codereview.tryton.org/56481002/diff/120001/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/56481002/diff/120001/trytond/trytond/model/modelstorage.py#newcode1240 trytond/trytond/model/modelstorage.py:1240: 'many2one': int, I do not see the point, it ...
2 months, 3 weeks ago (2019-01-22 10:16:40 UTC) #26
pokoli
Update to tip
2 months, 3 weeks ago (2019-01-22 10:38:09 UTC) #27
reviewbot
2 months, 3 weeks ago (2019-01-22 10:43:02 UTC) #28
https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:11:
F403 'from modelview import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:12:
F403 'from mptt import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:13:
F403 'from import_data import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:14:
F403 'from export_data import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:15:
F403 'from trigger import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:17:
F403 'from wizard import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:18:
F403 'from workflow import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:19:
F403 'from history import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/tests/__in...
trytond/trytond/tests/__init__.py:20:
F403 'from field_context import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/mode...
trytond/trytond/model/modelstorage.py:292:
E501 line too long (82 > 79 characters)

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/mode...
trytond/trytond/model/modelstorage.py:851:
E501 line too long (84 > 79 characters)

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/mode...
trytond/trytond/model/modelstorage.py:1025:
E501 line too long (82 > 79 characters)

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/mode...
trytond/trytond/model/modelstorage.py:1095:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:4:
F403 'from field import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:5:
F403 'from boolean import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:6:
F403 'from integer import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:7:
F403 'from char import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:8:
F403 'from text import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:9:
F403 'from float import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:10:
F403 'from numeric import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:11:
F403 'from date import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:12:
F403 'from binary import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:13:
F403 'from selection import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:14:
F403 'from reference import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:15:
F403 'from many2one import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:16:
F403 'from one2many import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:17:
F403 'from many2many import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:18:
F403 'from function import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:19:
F403 'from one2one import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:20:
F403 'from dict import *' used; unable to detect undefined names

https://codereview.tryton.org/56481002/diff/140001/trytond/trytond/model/fiel...
trytond/trytond/model/fields/__init__.py:21:
F403 'from array_ import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/56481002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766