Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 56481002: tryton-env: Add Array field

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by pokoli
Modified:
1 day, 3 hours ago
Reviewers:
dave, reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove unrelated code #

Total comments: 7

Patch Set 3 : Use typed arrays #

Total comments: 1

Patch Set 4 : Validate types for sqlite #

Patch Set 5 : Improve docstring #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -0 lines) Patch
M sao/src/model.js View 3 2 chunks +17 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/model/field.py View 3 2 chunks +15 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/models/fields.rst View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/trytond/model/fields/__init__.py View 3 1 chunk +1 line, -0 lines 0 comments Download
A trytond/trytond/model/fields/array_.py View 1 2 3 4 1 chunk +53 lines, -0 lines 1 comment Download
M trytond/trytond/tests/__init__.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A trytond/trytond/tests/field_array.py View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A trytond/trytond/tests/test_field_array.py View 1 2 3 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 16
pokoli
1 month, 1 week ago (2018-11-11 20:37:10 UTC) #1
reviewbot
https://codereview.tryton.org/56481002/diff/1/modules/company/__init__.py#newcode5 modules/company/__init__.py:5: F403 'from company import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/1/modules/company/__init__.py#newcode6 modules/company/__init__.py:6: ...
1 month, 1 week ago (2018-11-11 20:41:53 UTC) #2
albert
https://codereview.tryton.org/56481002/diff/1/modules/account_invoice/tests/test_account_invoice.py File modules/account_invoice/tests/test_account_invoice.py (right): https://codereview.tryton.org/56481002/diff/1/modules/account_invoice/tests/test_account_invoice.py#newcode210 modules/account_invoice/tests/test_account_invoice.py:210: @with_transaction() This should not be part of this review ...
1 month, 1 week ago (2018-11-11 21:26:03 UTC) #3
pokoli
Remove unrelated code
1 month, 1 week ago (2018-11-11 21:59:55 UTC) #4
reviewbot
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
1 month, 1 week ago (2018-11-11 22:10:24 UTC) #5
ced
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode13 trytond/trytond/model/fields/array_.py:13: _sql_type = 'TEXT' For me, we should use SQL ...
4 weeks, 1 day ago (2018-11-19 20:52:42 UTC) #6
pokoli
Use typed arrays
3 weeks, 6 days ago (2018-11-21 11:12:46 UTC) #7
pokoli
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode13 trytond/trytond/model/fields/array_.py:13: _sql_type = 'TEXT' On 2018/11/19 20:52:41, ced wrote: > ...
3 weeks, 6 days ago (2018-11-21 11:12:51 UTC) #8
reviewbot
patch is not applicable URL: https://codereview.tryton.org/56481002
3 weeks, 6 days ago (2018-11-21 11:43:22 UTC) #9
dave
https://codereview.tryton.org/56481002/diff/40001/trytond/model/fields/array_.py File trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/40001/trytond/model/fields/array_.py#newcode11 trytond/model/fields/array_.py:11: 'Define array field.' What about: ''' Define an array ...
3 weeks, 6 days ago (2018-11-21 14:43:35 UTC) #10
ced
https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py File trytond/trytond/model/fields/array_.py (right): https://codereview.tryton.org/56481002/diff/20001/trytond/trytond/model/fields/array_.py#newcode21 trytond/trytond/model/fields/array_.py:21: loading) On 2018/11/21 11:12:51, pokoli wrote: > On 2018/11/19 ...
3 weeks ago (2018-11-27 15:26:13 UTC) #11
pokoli
Validate types for sqlite
2 weeks ago (2018-12-04 12:13:41 UTC) #12
pokoli
Improve docstring
2 weeks ago (2018-12-04 12:15:43 UTC) #13
reviewbot
https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/tests/__init__.py#newcode11 trytond/trytond/tests/__init__.py:11: F403 'from modelview import *' used; unable to detect undefined names https://codereview.tryton.org/56481002/diff/80001/trytond/trytond/tests/__init__.py#newcode12 trytond/trytond/tests/__init__.py:12: ...
2 weeks ago (2018-12-04 12:44:58 UTC) #14
ced
I think the type should be added for Model.fields_get If we want to have one ...
1 day, 3 hours ago (2018-12-17 22:35:29 UTC) #15
ced
1 day, 3 hours ago (2018-12-17 22:36:15 UTC) #16
On 2018/12/17 22:35:29, ced wrote:
> I think the type should be added for Model.fields_get
> If we want to have one day widgets for those fields.

I think also the documentation should state that such field can not be used on
view.
Maybe we could add a generic test.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766