Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 58351002: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by udono
Modified:
1 day, 7 hours ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7034

Patch Set 1 #

Total comments: 23

Patch Set 2 : Pokoli's comments #

Patch Set 3 : Remove accidential new line #

Patch Set 4 : Update to tip rev6571df5d8026 and improve help messages #

Total comments: 5

Patch Set 5 : Remove tab from indentation #

Total comments: 6

Patch Set 6 : Apply changes from comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -37 lines) Patch
M trytond/res/group.py View 1 2 3 1 chunk +13 lines, -7 lines 0 comments Download
M trytond/res/ir.py View 1 2 3 5 chunks +12 lines, -7 lines 0 comments Download
M trytond/res/user.py View 1 2 3 4 5 5 chunks +41 lines, -21 lines 0 comments Download
M trytond/res/user.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/res/view/user_form_preferences.xml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21
udono
5 months ago (2018-07-16 06:41:18 UTC) #1
reviewbot
https://codereview.tryton.org/58351002/diff/1/trytond/res/ir.py#newcode125 trytond/res/ir.py:125: F841 local variable 'database' is assigned to but never used https://codereview.tryton.org/58351002/diff/1/trytond/res/user.py#newcode634 trytond/res/user.py:634: E712 ...
5 months ago (2018-07-16 06:43:03 UTC) #2
pokoli
https://codereview.tryton.org/58351002/diff/1/trytond/res/group.py File trytond/res/group.py (right): https://codereview.tryton.org/58351002/diff/1/trytond/res/group.py#newcode36 trytond/res/group.py:36: help="Manage users controlled by the group.") I think its ...
4 months, 2 weeks ago (2018-08-01 11:31:18 UTC) #3
udono
Pokoli's comments
4 months, 2 weeks ago (2018-08-06 11:46:32 UTC) #4
udono
https://tryton-rietveld.appspot.com/58351002/diff/1/trytond/res/group.py File trytond/res/group.py (right): https://tryton-rietveld.appspot.com/58351002/diff/1/trytond/res/group.py#newcode38 trytond/res/group.py:38: 'Access Model', help="Add access models to the group.") On ...
4 months, 2 weeks ago (2018-08-06 11:48:25 UTC) #5
reviewbot
https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode112 trytond/res/user.py:112: E901 SyntaxError: invalid syntax https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode1044 trytond/res/user.py:1044: E901 TokenError: EOF in multi-line statement https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode627 ...
4 months, 2 weeks ago (2018-08-06 12:12:03 UTC) #6
udono
Remove accidential new line
4 months, 2 weeks ago (2018-08-06 12:54:48 UTC) #7
reviewbot
https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode112 trytond/res/user.py:112: E901 SyntaxError: invalid syntax https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode1044 trytond/res/user.py:1044: E901 TokenError: EOF in multi-line statement https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode627 ...
4 months, 2 weeks ago (2018-08-06 13:11:02 UTC) #8
udono
On 2018/08/01 11:31:18, pokoli wrote: > https://codereview.tryton.org/58351002/diff/1/trytond/res/view/user_application_form.xml#newcode16 > trytond/res/view/user_application_form.xml:16: help="Cancel the application > request."/> > ...
4 months, 2 weeks ago (2018-08-06 13:25:13 UTC) #9
udono
the patch applies on rev42cd96d58788
2 weeks, 6 days ago (2018-11-28 16:21:31 UTC) #10
dave
Update to tip rev6571df5d8026 and improve help messages
1 week, 6 days ago (2018-12-05 13:12:47 UTC) #11
dave
Hi, I've got a few questions about this code review that I'm hoping someone can ...
1 week, 6 days ago (2018-12-05 13:18:46 UTC) #12
reviewbot
https://codereview.tryton.org/58351002/diff/60001/trytond/res/user.py#newcode627 trytond/res/user.py:627: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 week, 6 days ago (2018-12-05 13:46:31 UTC) #13
dave
Remove tab from indentation
1 week, 6 days ago (2018-12-05 18:26:48 UTC) #14
reviewbot
https://codereview.tryton.org/58351002/diff/80001/trytond/res/user.py#newcode627 trytond/res/user.py:627: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 week, 6 days ago (2018-12-05 18:39:07 UTC) #15
udono
https://codereview.tryton.org/58351002/diff/80001/trytond/res/user.py File trytond/res/user.py (right): https://codereview.tryton.org/58351002/diff/80001/trytond/res/user.py#newcode137 trytond/res/user.py:137: help="The applications connected to the account.") maybe better "user ...
2 days, 8 hours ago (2018-12-16 17:20:31 UTC) #16
dave
Apply changes from comments
1 day, 12 hours ago (2018-12-17 13:26:39 UTC) #17
dave
I also have a few additional things that I wasn't too sure about: https://codereview.tryton.org/58351002/diff/60001/trytond/res/user.py ------------ ...
1 day, 12 hours ago (2018-12-17 13:26:44 UTC) #18
reviewbot
https://codereview.tryton.org/58351002/diff/100001/trytond/res/user.py#newcode627 trytond/res/user.py:627: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 day, 12 hours ago (2018-12-17 13:40:44 UTC) #19
pokoli
https://codereview.tryton.org/58351002/diff/80001/trytond/res/view/user_form_preferences.xml File trytond/res/view/user_form_preferences.xml (right): https://codereview.tryton.org/58351002/diff/80001/trytond/res/view/user_form_preferences.xml#newcode10 trytond/res/view/user_form_preferences.xml:10: <field name="email" widget="email" help="Your email address used for communications ...
1 day, 11 hours ago (2018-12-17 14:39:30 UTC) #20
pokoli
1 day, 7 hours ago (2018-12-17 18:46:05 UTC) #21
https://codereview.tryton.org/58351002/diff/60001/trytond/res/user.py
File trytond/res/user.py (right):

https://codereview.tryton.org/58351002/diff/60001/trytond/res/user.py#newcode135
trytond/res/user.py:135: applications = fields.One2Many(
On 2018/12/05 13:18:46, dave wrote:
> The same goes for this field as well.

I see the tooltip is shown for the lines field of the product_price_list module.
As far as it's the same type as this field it should be also shown. 

Could you test with the price list module? 

If the help is not shown maybe it's because you are not placing the mouse on the
right position. I see it when the mouse is over one of the lines or when it's
over the field Label. 

If you put the mouse over the Widget buttons the button tooltip is shown. 

If nothing of the above works for you please fill a bug
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766