Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 58351002: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by udono
Modified:
2 months, 1 week ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 23

Patch Set 2 : Pokoli's comments #

Patch Set 3 : Remove accidential new line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -39 lines) Patch
M trytond/res/group.py View 1 chunk +12 lines, -7 lines 0 comments Download
M trytond/res/ir.py View 1 5 chunks +9 lines, -7 lines 0 comments Download
M trytond/res/user.py View 1 5 chunks +42 lines, -25 lines 0 comments Download
M trytond/res/user.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
udono
3 months ago (2018-07-16 06:41:18 UTC) #1
reviewbot
https://codereview.tryton.org/58351002/diff/1/trytond/res/ir.py#newcode125 trytond/res/ir.py:125: F841 local variable 'database' is assigned to but never used https://codereview.tryton.org/58351002/diff/1/trytond/res/user.py#newcode634 trytond/res/user.py:634: E712 ...
3 months ago (2018-07-16 06:43:03 UTC) #2
pokoli
https://codereview.tryton.org/58351002/diff/1/trytond/res/group.py File trytond/res/group.py (right): https://codereview.tryton.org/58351002/diff/1/trytond/res/group.py#newcode36 trytond/res/group.py:36: help="Manage users controlled by the group.") I think its ...
2 months, 2 weeks ago (2018-08-01 11:31:18 UTC) #3
udono
Pokoli's comments
2 months, 1 week ago (2018-08-06 11:46:32 UTC) #4
udono
https://tryton-rietveld.appspot.com/58351002/diff/1/trytond/res/group.py File trytond/res/group.py (right): https://tryton-rietveld.appspot.com/58351002/diff/1/trytond/res/group.py#newcode38 trytond/res/group.py:38: 'Access Model', help="Add access models to the group.") On ...
2 months, 1 week ago (2018-08-06 11:48:25 UTC) #5
reviewbot
https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode112 trytond/res/user.py:112: E901 SyntaxError: invalid syntax https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode1044 trytond/res/user.py:1044: E901 TokenError: EOF in multi-line statement https://codereview.tryton.org/58351002/diff/20001/trytond/res/user.py#newcode627 ...
2 months, 1 week ago (2018-08-06 12:12:03 UTC) #6
udono
Remove accidential new line
2 months, 1 week ago (2018-08-06 12:54:48 UTC) #7
reviewbot
https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode112 trytond/res/user.py:112: E901 SyntaxError: invalid syntax https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode1044 trytond/res/user.py:1044: E901 TokenError: EOF in multi-line statement https://codereview.tryton.org/58351002/diff/40001/trytond/res/user.py#newcode627 ...
2 months, 1 week ago (2018-08-06 13:11:02 UTC) #8
udono
2 months, 1 week ago (2018-08-06 13:25:13 UTC) #9
On 2018/08/01 11:31:18, pokoli wrote:
>
https://codereview.tryton.org/58351002/diff/1/trytond/res/view/user_applicati...
> trytond/res/view/user_application_form.xml:16: help="Cancel the application
> request."/>
> It should be registered on ir.button.access which allows to set the help and
> then the server sets it on all views.

I also checked the other reviews and fixed them.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766