Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 58351003: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by udono
Modified:
3 months ago
Reviewers:
pokoli, reviewbot, dave
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7034

Patch Set 1 #

Total comments: 6

Patch Set 2 : Update tip #

Patch Set 3 : Pokoli's comments #

Total comments: 9

Patch Set 4 : Update to tip and improve help text #

Total comments: 8

Patch Set 5 : Apply changes from comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M doc/ref/models/models.rst View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M trytond/model/dictschema.py View 1 2 3 4 2 chunks +18 lines, -7 lines 0 comments Download
M trytond/model/model.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M trytond/model/modelstorage.py View 1 2 3 4 1 chunk +12 lines, -7 lines 0 comments Download
M trytond/model/order.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19
udono
8 months, 1 week ago (2018-07-16 06:43:25 UTC) #1
reviewbot
https://codereview.tryton.org/58351003/diff/1/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/1/trytond/model/model.py#newcode244 trytond/model/model.py:244: E127 continuation line over-indented ...
8 months, 1 week ago (2018-07-16 07:12:55 UTC) #2
pokoli
https://codereview.tryton.org/58351003/diff/1/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://codereview.tryton.org/58351003/diff/1/trytond/model/modelstorage.py#newcode52 trytond/model/modelstorage.py:52: help="The database id of the user who created the ...
7 months, 3 weeks ago (2018-08-01 11:34:07 UTC) #3
udono
Update tip
7 months, 2 weeks ago (2018-08-06 11:53:02 UTC) #4
udono
Pokoli's comments
7 months, 2 weeks ago (2018-08-06 12:01:44 UTC) #5
udono
https://tryton-rietveld.appspot.com/58351003/diff/1/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://tryton-rietveld.appspot.com/58351003/diff/1/trytond/model/modelstorage.py#newcode52 trytond/model/modelstorage.py:52: help="The database id of the user who created the ...
7 months, 2 weeks ago (2018-08-06 12:02:01 UTC) #6
reviewbot
https://codereview.tryton.org/58351003/diff/40001/trytond/model/model.py#newcode189 trytond/model/model.py:189: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/40001/trytond/model/model.py#newcode252 trytond/model/model.py:252: E127 continuation line over-indented ...
7 months, 2 weeks ago (2018-08-06 12:12:26 UTC) #7
pokoli
https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py#newcode18 trytond/model/dictschema.py:18: help="The human readable name of the key.") I'm wondering ...
3 months, 3 weeks ago (2018-11-26 09:14:54 UTC) #8
dave
https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py#newcode16 trytond/model/dictschema.py:16: help="The main identifier of the key.") Following pokoli's suggestion: ...
3 months, 3 weeks ago (2018-11-26 12:49:35 UTC) #9
dave
Update to tip and improve help text
3 months, 3 weeks ago (2018-11-28 12:55:56 UTC) #10
reviewbot
https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py#newcode188 trytond/model/model.py:188: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py#newcode251 trytond/model/model.py:251: E127 continuation line over-indented ...
3 months, 3 weeks ago (2018-11-28 13:12:29 UTC) #11
udono
I don't know, how you make the updates to tip, but you can use a ...
3 months, 3 weeks ago (2018-11-28 15:46:17 UTC) #12
dave
On 2018/11/28 15:46:17, udono wrote: > I don't know, how you make the updates to ...
3 months, 3 weeks ago (2018-11-28 16:04:01 UTC) #13
udono
On 2018/11/28 16:04:01, dave wrote: > On 2018/11/28 15:46:17, udono wrote: > > I don't ...
3 months, 3 weeks ago (2018-11-28 16:28:48 UTC) #14
dave
On 2018/11/28 16:28:48, udono wrote: > for each review, you can try: > > hg ...
3 months, 3 weeks ago (2018-11-28 16:38:54 UTC) #15
udono
https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py#newcode33 trytond/model/dictschema.py:33: domain = fields.Char("Domain") missing help? https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py File trytond/model/model.py (right): ...
3 months ago (2018-12-15 07:07:00 UTC) #16
dave
Apply changes from comments.
3 months ago (2018-12-17 13:02:46 UTC) #17
dave
https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py#newcode33 trytond/model/dictschema.py:33: domain = fields.Char("Domain") On 2018/12/15 07:07:00, udono wrote: > ...
3 months ago (2018-12-17 13:02:54 UTC) #18
reviewbot
3 months ago (2018-12-17 13:10:59 UTC) #19
https://codereview.tryton.org/58351003/diff/80001/trytond/model/model.py#newc...
trytond/model/model.py:187:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/58351003/diff/80001/trytond/model/model.py#newc...
trytond/model/model.py:250:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/58351003/diff/80001/trytond/model/model.py#newc...
trytond/model/model.py:276:
E127 continuation line over-indented for visual indent

https://codereview.tryton.org/58351003/diff/80001/trytond/model/modelstorage....
trytond/model/modelstorage.py:243:
E501 line too long (82 > 79 characters)

https://codereview.tryton.org/58351003/diff/80001/trytond/model/modelstorage....
trytond/model/modelstorage.py:782:
E501 line too long (84 > 79 characters)

https://codereview.tryton.org/58351003/diff/80001/trytond/model/modelstorage....
trytond/model/modelstorage.py:967:
E501 line too long (82 > 79 characters)

URL: https://codereview.tryton.org/58351003
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766