Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 58351003: trytond: Add help texts.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by udono
Modified:
1 day, 5 hours ago
Reviewers:
pokoli, reviewbot, dave
Visibility:
Public.

Description

COLLABORATOR=dave@liberteq.org issue7034

Patch Set 1 #

Total comments: 6

Patch Set 2 : Update tip #

Patch Set 3 : Pokoli's comments #

Total comments: 9

Patch Set 4 : Update to tip and improve help text #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M doc/ref/models/models.rst View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M trytond/model/dictschema.py View 1 2 3 2 chunks +13 lines, -6 lines 1 comment Download
M trytond/model/model.py View 1 2 3 1 chunk +1 line, -0 lines 2 comments Download
M trytond/model/modelstorage.py View 1 2 3 1 chunk +12 lines, -6 lines 1 comment Download
M trytond/model/order.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16
udono
5 months ago (2018-07-16 06:43:25 UTC) #1
reviewbot
https://codereview.tryton.org/58351003/diff/1/trytond/model/model.py#newcode181 trytond/model/model.py:181: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/1/trytond/model/model.py#newcode244 trytond/model/model.py:244: E127 continuation line over-indented ...
5 months ago (2018-07-16 07:12:55 UTC) #2
pokoli
https://codereview.tryton.org/58351003/diff/1/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://codereview.tryton.org/58351003/diff/1/trytond/model/modelstorage.py#newcode52 trytond/model/modelstorage.py:52: help="The database id of the user who created the ...
4 months, 2 weeks ago (2018-08-01 11:34:07 UTC) #3
udono
Update tip
4 months, 1 week ago (2018-08-06 11:53:02 UTC) #4
udono
Pokoli's comments
4 months, 1 week ago (2018-08-06 12:01:44 UTC) #5
udono
https://tryton-rietveld.appspot.com/58351003/diff/1/trytond/model/modelstorage.py File trytond/model/modelstorage.py (right): https://tryton-rietveld.appspot.com/58351003/diff/1/trytond/model/modelstorage.py#newcode52 trytond/model/modelstorage.py:52: help="The database id of the user who created the ...
4 months, 1 week ago (2018-08-06 12:02:01 UTC) #6
reviewbot
https://codereview.tryton.org/58351003/diff/40001/trytond/model/model.py#newcode189 trytond/model/model.py:189: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/40001/trytond/model/model.py#newcode252 trytond/model/model.py:252: E127 continuation line over-indented ...
4 months, 1 week ago (2018-08-06 12:12:26 UTC) #7
pokoli
https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py#newcode18 trytond/model/dictschema.py:18: help="The human readable name of the key.") I'm wondering ...
2 weeks, 6 days ago (2018-11-26 09:14:54 UTC) #8
dave
https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py File trytond/model/dictschema.py (right): https://codereview.tryton.org/58351003/diff/40001/trytond/model/dictschema.py#newcode16 trytond/model/dictschema.py:16: help="The main identifier of the key.") Following pokoli's suggestion: ...
2 weeks, 5 days ago (2018-11-26 12:49:35 UTC) #9
dave
Update to tip and improve help text
2 weeks, 3 days ago (2018-11-28 12:55:56 UTC) #10
reviewbot
https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py#newcode188 trytond/model/model.py:188: E127 continuation line over-indented for visual indent https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py#newcode251 trytond/model/model.py:251: E127 continuation line over-indented ...
2 weeks, 3 days ago (2018-11-28 13:12:29 UTC) #11
udono
I don't know, how you make the updates to tip, but you can use a ...
2 weeks, 3 days ago (2018-11-28 15:46:17 UTC) #12
dave
On 2018/11/28 15:46:17, udono wrote: > I don't know, how you make the updates to ...
2 weeks, 3 days ago (2018-11-28 16:04:01 UTC) #13
udono
On 2018/11/28 16:04:01, dave wrote: > On 2018/11/28 15:46:17, udono wrote: > > I don't ...
2 weeks, 3 days ago (2018-11-28 16:28:48 UTC) #14
dave
On 2018/11/28 16:28:48, udono wrote: > for each review, you can try: > > hg ...
2 weeks, 3 days ago (2018-11-28 16:38:54 UTC) #15
udono
1 day, 5 hours ago (2018-12-15 07:07:00 UTC) #16
https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py
File trytond/model/dictschema.py (right):

https://codereview.tryton.org/58351003/diff/60001/trytond/model/dictschema.py...
trytond/model/dictschema.py:33: domain = fields.Char("Domain")
missing help?

https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py
File trytond/model/model.py (right):

https://codereview.tryton.org/58351003/diff/60001/trytond/model/model.py#newc...
trytond/model/model.py:30: Define a model in Tryton.
maybe remove "Define a model in Tryton."???

https://codereview.tryton.org/58351003/diff/60001/trytond/model/modelstorage.py
File trytond/model/modelstorage.py (right):

https://codereview.tryton.org/58351003/diff/60001/trytond/model/modelstorage....
trytond/model/modelstorage.py:55: Define a model with storage capability in
Tryton.
Maybe remove "Define a model with storage capability in Tryton."
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766