Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 58441002: trytond: Improve the access right documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by ced
Modified:
1 day, 2 hours ago
Reviewers:
pokoli, reviewbot, rietveld-bot, dave
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix remarks #

Total comments: 12

Patch Set 3 : Fix comments #

Patch Set 4 : Fix domain validation #

Total comments: 1

Patch Set 5 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -30 lines) Patch
M doc/topics/access_rights.rst View 1 2 3 4 1 chunk +82 lines, -30 lines 0 comments Download

Messages

Total messages: 19
ced
2 weeks, 4 days ago (2018-11-30 17:17:41 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/58441002
2 weeks, 4 days ago (2018-11-30 17:42:05 UTC) #2
pokoli
https://codereview.tryton.org/58441002/diff/1/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/1/doc/topics/access_rights.rst#newcode15 doc/topics/access_rights.rst:15: :attr:`~trytond.transaction.Transaction.user` is `root`. Isn't the other way arround? they ...
2 weeks, 1 day ago (2018-12-03 09:18:05 UTC) #3
ced
Fix remarks
2 weeks, 1 day ago (2018-12-03 09:36:52 UTC) #4
ced
https://codereview.tryton.org/58441002/diff/1/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/1/doc/topics/access_rights.rst#newcode15 doc/topics/access_rights.rst:15: :attr:`~trytond.transaction.Transaction.user` is `root`. On 2018/12/03 09:18:05, pokoli wrote: > ...
2 weeks, 1 day ago (2018-12-03 09:36:56 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/58441002
2 weeks, 1 day ago (2018-12-03 09:37:40 UTC) #6
dave
A few suggestions to help the text flow better. https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst#newcode8 doc/topics/access_rights.rst:8: ...
2 weeks, 1 day ago (2018-12-03 16:23:56 UTC) #7
ced
https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst#newcode97 doc/topics/access_rights.rst:97: A rule group match a record if it validate ...
2 weeks, 1 day ago (2018-12-03 23:34:22 UTC) #8
ced
Fix comments
2 weeks, 1 day ago (2018-12-03 23:34:23 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/58441002
2 weeks, 1 day ago (2018-12-03 23:38:13 UTC) #10
dave
https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/20001/doc/topics/access_rights.rst#newcode97 doc/topics/access_rights.rst:97: A rule group match a record if it validate ...
2 weeks ago (2018-12-04 09:58:01 UTC) #11
ced
Fix domain validation
2 weeks ago (2018-12-04 10:09:47 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/58441002
2 weeks ago (2018-12-04 10:47:35 UTC) #13
dave
https://codereview.tryton.org/58441002/diff/60001/doc/topics/access_rights.rst File doc/topics/access_rights.rst (right): https://codereview.tryton.org/58441002/diff/60001/doc/topics/access_rights.rst#newcode64 doc/topics/access_rights.rst:64: groups to be granted to use it. Sorry, missed ...
2 weeks ago (2018-12-04 11:28:11 UTC) #14
ced
Fix remarks
2 weeks ago (2018-12-04 11:49:45 UTC) #15
reviewbot
flake8 OK URL: https://codereview.tryton.org/58441002
2 weeks ago (2018-12-04 12:08:43 UTC) #16
dave
LGTM
2 weeks ago (2018-12-04 15:41:39 UTC) #17
rietveld-bot_tryton.org
New changeset b3f4769d5ea4 by Cédric Krier in branch 'default': Improve the access right documentation https://hg.tryton.org/trytond/rev/b3f4769d5ea4
1 day, 2 hours ago (2018-12-17 22:23:14 UTC) #18
rietveld-bot_tryton.org
1 day, 2 hours ago (2018-12-17 22:23:17 UTC) #19
New changeset 7c08948efa66 by Cédric Krier in branch 'default':
Improve the access right documentation
https://hg.tryton.org/tryton-env/rev/7c08948efa66
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766