Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2137)

Issue 58531002: stock_supply: Use OR clauses on location searcher (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by pokoli
Modified:
2 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use same level for OR clause and add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M order_point.py View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/test_stock_supply.py View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
3 months ago (2019-02-22 18:28:10 UTC) #1
reviewbot
https://codereview.tryton.org/58531002/diff/1/order_point.py#newcode56 order_point.py:56: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/58531002/diff/1/order_point.py#newcode65 order_point.py:65: ...
3 months ago (2019-02-22 18:35:35 UTC) #2
ced
https://codereview.tryton.org/58531002/diff/1/order_point.py File order_point.py (right): https://codereview.tryton.org/58531002/diff/1/order_point.py#newcode247 order_point.py:247: return ['OR', clauses] The 'OR' will have no effect ...
2 months, 4 weeks ago (2019-02-22 23:38:25 UTC) #3
pokoli
Use same level for OR clause and add test
2 months, 3 weeks ago (2019-02-28 18:41:45 UTC) #4
pokoli
https://codereview.tryton.org/58531002/diff/1/order_point.py File order_point.py (right): https://codereview.tryton.org/58531002/diff/1/order_point.py#newcode247 order_point.py:247: return ['OR', clauses] On 2019/02/22 23:38:24, ced wrote: > ...
2 months, 3 weeks ago (2019-02-28 18:42:05 UTC) #5
reviewbot
https://codereview.tryton.org/58531002/diff/20001/order_point.py#newcode56 order_point.py:56: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/58531002/diff/20001/order_point.py#newcode65 order_point.py:65: ...
2 months, 3 weeks ago (2019-02-28 18:42:41 UTC) #6
ced
LGTM but push test in a separate commit.
2 months, 2 weeks ago (2019-03-04 10:03:37 UTC) #7
rietveld-bot_tryton.org
New changeset b5dff78398eb by Sergi Almacellas Abellana in branch 'default': Use OR clauses on location ...
2 months, 1 week ago (2019-03-15 16:50:51 UTC) #8
rietveld-bot_tryton.org
New changeset d45cc934ef7a by Sergi Almacellas Abellana in branch 'default': Use OR clauses on location ...
2 months, 1 week ago (2019-03-15 16:51:04 UTC) #9
rietveld-bot_tryton.org
2 months ago (2019-03-24 14:38:07 UTC) #10
New changeset 226e45e1e9fc by Sergi Almacellas Abellana in branch '5.0':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/226e45e1e9fc


New changeset 104413718ffd by Sergi Almacellas Abellana in branch '4.8':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/104413718ffd


New changeset 35b587f2a689 by Sergi Almacellas Abellana in branch '4.6':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/35b587f2a689


New changeset cac8a60c084c by Sergi Almacellas Abellana in branch '4.4':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/cac8a60c084c


New changeset ffe683caf404 by Sergi Almacellas Abellana in branch '4.2':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/ffe683caf404
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766