Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(860)

Issue 60421002: account: Ensure GL per periods or dates are the same (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by ced
Modified:
5 months, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

We should not use nonexistent period ids in the context and the start_date must be excluded from the start computation because it is included in the range (query_get use greater and lesser or equal). issue7628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M account.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6
ced
6 months, 3 weeks ago (2018-11-02 20:55:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/60421002
6 months, 3 weeks ago (2018-11-02 20:58:44 UTC) #2
pokoli
LGTM
6 months, 2 weeks ago (2018-11-03 17:17:15 UTC) #3
rietveld-bot_tryton.org
New changeset ddae9f9c21f4 by Cédric Krier in branch 'default': Ensure GL per periods or dates ...
6 months ago (2018-11-18 11:06:00 UTC) #4
rietveld-bot_tryton.org
New changeset 998f55624214 by Cédric Krier in branch 'default': Ensure GL per periods or dates ...
6 months ago (2018-11-18 11:06:08 UTC) #5
rietveld-bot_tryton.org
5 months, 4 weeks ago (2018-11-25 21:00:26 UTC) #6
New changeset 1f96addd993e by Cédric Krier in branch '5.0':
Ensure GL per periods or dates are the same
https://hg.tryton.org/modules/account/rev/1f96addd993e


New changeset 8ab4f5aaca0f by Cédric Krier in branch '4.8':
Ensure GL per periods or dates are the same
https://hg.tryton.org/modules/account/rev/8ab4f5aaca0f


New changeset 7c818895032d by Cédric Krier in branch '4.6':
Ensure GL per periods or dates are the same
https://hg.tryton.org/modules/account/rev/7c818895032d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766