Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 60551002: tryton-env: Display ids and rule names on access error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 2 weeks ago
Reviewers:
pokoli, reviewbot, rietveld-bot, dave
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Better help message #

Total comments: 12

Patch Set 3 : Improve error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -81 lines) Patch
M modules/account/account.xml View 5 chunks +5 lines, -0 lines 0 comments Download
M modules/account/fiscalyear.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account/period.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account/tax.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/account_asset/asset.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_dunning/dunning.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_invoice/account.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_invoice/invoice.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/account_payment/payment.xml View 3 chunks +3 lines, -0 lines 0 comments Download
M modules/account_payment_sepa/payment.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/account_product/product.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/account_statement/journal.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_statement/statement.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/account_stock_landed_cost/account.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/analytic_account/rule.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/company/company.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/product_price_list/price_list.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/production/production.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/production_work/work.xml View 3 chunks +3 lines, -0 lines 0 comments Download
M modules/project_invoice/timesheet.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/purchase/purchase.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/purchase_request/purchase_request.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/purchase_request_quotation/purchase.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/purchase_requisition/purchase.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/sale/sale.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/sale_complaint/complaint.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/sale_extra/sale.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/sale_opportunity/opportunity.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/sale_promotion/sale.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/sale_supply_drop_shipment/stock.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/move.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/stock/shipment.xml View 5 chunks +5 lines, -0 lines 0 comments Download
M modules/stock_location_move/stock.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/stock_supply/order_point.xml View 1 chunk +1 line, -0 lines 0 comments Download
M modules/timesheet/line.xml View 4 chunks +4 lines, -0 lines 0 comments Download
M modules/timesheet/work.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M trytond/CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 2 1 chunk +18 lines, -2 lines 0 comments Download
M trytond/trytond/ir/rule.py View 1 6 chunks +62 lines, -44 lines 0 comments Download
M trytond/trytond/model/modelsql.py View 2 chunks +70 lines, -30 lines 0 comments Download
M trytond/trytond/res/ir.xml View 14 chunks +14 lines, -0 lines 0 comments Download
M trytond/trytond/res/user.xml View 3 chunks +3 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_rule.py View 16 chunks +43 lines, -5 lines 0 comments Download

Messages

Total messages: 45
ced
2 months, 1 week ago (2019-02-08 13:46:08 UTC) #1
reviewbot
https://codereview.tryton.org/60551002/diff/1/trytond/trytond/model/modelsql.py#newcode375 trytond/trytond/model/modelsql.py:375: E127 continuation line over-indented for visual indent https://codereview.tryton.org/60551002/diff/1/trytond/trytond/ir/rule.py#newcode53 trytond/trytond/ir/rule.py:53: E712 comparison to False ...
2 months, 1 week ago (2019-02-08 14:20:05 UTC) #2
pokoli
https://codereview.tryton.org/60551002/diff/1/trytond/trytond/ir/rule.py File trytond/trytond/ir/rule.py (right): https://codereview.tryton.org/60551002/diff/1/trytond/trytond/ir/rule.py#newcode27 trytond/trytond/ir/rule.py:27: help="Display to users when access error are raised.") Display ...
2 months, 1 week ago (2019-02-09 18:25:51 UTC) #3
ced
https://codereview.tryton.org/60551002/diff/1/trytond/trytond/ir/rule.py File trytond/trytond/ir/rule.py (right): https://codereview.tryton.org/60551002/diff/1/trytond/trytond/ir/rule.py#newcode27 trytond/trytond/ir/rule.py:27: help="Display to users when access error are raised.") On ...
2 months, 1 week ago (2019-02-09 18:40:08 UTC) #4
ced
2 months, 1 week ago (2019-02-09 18:45:15 UTC) #5
reviewbot
https://codereview.tryton.org/60551002/diff/20001/trytond/trytond/model/modelsql.py#newcode375 trytond/trytond/model/modelsql.py:375: E127 continuation line over-indented for visual indent https://codereview.tryton.org/60551002/diff/20001/trytond/trytond/ir/rule.py#newcode53 trytond/trytond/ir/rule.py:53: E712 comparison to False ...
2 months, 1 week ago (2019-02-09 18:52:20 UTC) #6
dave
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> When displayed in the error ...
2 months ago (2019-02-13 22:43:00 UTC) #7
ced
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> On 2019/02/13 22:43:00, dave wrote: ...
2 months ago (2019-02-14 10:46:45 UTC) #8
ced
2 months ago (2019-02-14 10:51:38 UTC) #9
reviewbot
https://codereview.tryton.org/60551002/diff/40001/trytond/trytond/model/modelsql.py#newcode375 trytond/trytond/model/modelsql.py:375: E127 continuation line over-indented for visual indent https://codereview.tryton.org/60551002/diff/40001/trytond/trytond/ir/rule.py#newcode53 trytond/trytond/ir/rule.py:53: E712 comparison to False ...
2 months ago (2019-02-14 11:20:50 UTC) #10
dave
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> On 2019/02/14 10:46:45, ced wrote: ...
2 months ago (2019-02-14 12:01:48 UTC) #11
ced
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> On 2019/02/14 12:01:48, dave wrote: ...
1 month, 4 weeks ago (2019-02-18 17:19:47 UTC) #12
ced
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> On 2019/02/18 17:19:47, ced wrote: ...
1 month, 4 weeks ago (2019-02-18 17:20:25 UTC) #13
dave
https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml File modules/account/tax.xml (right): https://codereview.tryton.org/60551002/diff/20001/modules/account/tax.xml#newcode186 modules/account/tax.xml:186: <field name="name">User in company</field> On 2019/02/18 17:20:25, ced wrote: ...
1 month, 3 weeks ago (2019-02-20 17:19:50 UTC) #14
rietveld-bot_tryton.org
New changeset 23a12b1d584c by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:33 UTC) #15
rietveld-bot_tryton.org
New changeset 8899a928233d by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:38 UTC) #16
rietveld-bot_tryton.org
New changeset a7ef732e7c6c by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:44 UTC) #17
rietveld-bot_tryton.org
New changeset 6c899fe34e72 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:48 UTC) #18
rietveld-bot_tryton.org
New changeset 596ab81e0d21 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:53 UTC) #19
rietveld-bot_tryton.org
New changeset c3052c88c133 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:11:58 UTC) #20
rietveld-bot_tryton.org
New changeset dbe2972739df by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:00 UTC) #21
rietveld-bot_tryton.org
New changeset 5319858172fa by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:05 UTC) #22
rietveld-bot_tryton.org
New changeset 67c55a1660d0 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:08 UTC) #23
rietveld-bot_tryton.org
New changeset ff98a517103b by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:13 UTC) #24
rietveld-bot_tryton.org
New changeset e28faf697bf4 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:19 UTC) #25
rietveld-bot_tryton.org
New changeset a2803461b002 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:25 UTC) #26
rietveld-bot_tryton.org
New changeset f65369cadeeb by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:31 UTC) #27
rietveld-bot_tryton.org
New changeset a550a2e19ab5 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:38 UTC) #28
rietveld-bot_tryton.org
New changeset 6ec6ccbc98b2 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:42 UTC) #29
rietveld-bot_tryton.org
New changeset 7f70807f0af6 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:45 UTC) #30
rietveld-bot_tryton.org
New changeset b8b169c68f5e by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:51 UTC) #31
rietveld-bot_tryton.org
New changeset c6b3b51cbaa7 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:53 UTC) #32
rietveld-bot_tryton.org
New changeset a653703294a5 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:57 UTC) #33
rietveld-bot_tryton.org
New changeset 2b14d2cb9660 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:12:59 UTC) #34
rietveld-bot_tryton.org
New changeset 86ebba81e2eb by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:01 UTC) #35
rietveld-bot_tryton.org
New changeset 1367084fed57 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:04 UTC) #36
rietveld-bot_tryton.org
New changeset 990ab51bc6d3 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:07 UTC) #37
rietveld-bot_tryton.org
New changeset 4baa5937bd07 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:10 UTC) #38
rietveld-bot_tryton.org
New changeset 25861f6d9b4b by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:14 UTC) #39
rietveld-bot_tryton.org
New changeset d7933577b5d7 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:17 UTC) #40
rietveld-bot_tryton.org
New changeset 5bc58ce7d86a by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:19 UTC) #41
rietveld-bot_tryton.org
New changeset 509a6eb0477d by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:22 UTC) #42
rietveld-bot_tryton.org
New changeset 4f9e511a2631 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:26 UTC) #43
rietveld-bot_tryton.org
New changeset 91206db779f0 by Cédric Krier in branch 'default': Display ids and rule names on ...
1 month, 2 weeks ago (2019-03-03 22:13:30 UTC) #44
rietveld-bot_tryton.org
1 month, 2 weeks ago (2019-03-03 22:13:33 UTC) #45
New changeset 215dcfe24384 by Cédric Krier in branch 'default':
Display ids and rule names on access error
https://hg.tryton.org/tryton-env/rev/215dcfe24384
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766