Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 60581002: sao: Remove unnecessary calls to fields_view_get (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ced
Modified:
2 months ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

Screen.count_tab_domain should be called after the switch_view as it is done in tryton. This avoid to trigger a call to fields_view_get for the domain_parser. Screen.switch_view is performing one extra loop compared to tryton. This trigger and extra call fields_view_get. issue8167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M src/screen.js View 3 chunks +34 lines, -17 lines 0 comments Download
M src/tab.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
ced
2 months, 2 weeks ago (2019-03-04 09:26:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/60581002
2 months, 2 weeks ago (2019-03-04 09:41:30 UTC) #2
rietveld-bot_tryton.org
New changeset 46f47d631ee2 by Cédric Krier in branch 'default': Remove unnecessary calls to fields_view_get https://hg.tryton.org/sao/rev/46f47d631ee2
2 months, 1 week ago (2019-03-15 10:14:34 UTC) #3
rietveld-bot_tryton.org
New changeset 622c14fdcde1 by Cédric Krier in branch 'default': Remove unnecessary calls to fields_view_get https://hg.tryton.org/tryton-env/rev/622c14fdcde1
2 months, 1 week ago (2019-03-15 10:14:35 UTC) #4
rietveld-bot_tryton.org
2 months ago (2019-03-24 14:38:24 UTC) #5
New changeset c6d4386ad622 by Cédric Krier in branch '5.0':
Remove unnecessary calls to fields_view_get
https://hg.tryton.org/sao/rev/c6d4386ad622
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766