Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 60591002: sao: Connect only once wizard dialog to keydown (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by ced
Modified:
3 weeks, 4 days ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

update is called on each state so it binds multiple times to keydown and call multiple times response with end state. This results in trying to delete multiple times the same wizard session which fails. issue8179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/wizard.js View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5
ced
1 month, 1 week ago (2019-03-06 18:15:34 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/60591002
1 month, 1 week ago (2019-03-06 18:20:18 UTC) #2
rietveld-bot_tryton.org
New changeset e937c0f4b24b by Cédric Krier in branch 'default': Connect only once wizard dialog to ...
1 month ago (2019-03-15 10:18:28 UTC) #3
rietveld-bot_tryton.org
New changeset 1e25beb18bcc by Cédric Krier in branch 'default': Connect only once wizard dialog to ...
1 month ago (2019-03-15 10:18:31 UTC) #4
rietveld-bot_tryton.org
3 weeks, 4 days ago (2019-03-24 14:38:23 UTC) #5
New changeset 552889095191 by Cédric Krier in branch '5.0':
Connect only once wizard dialog to keydown
https://hg.tryton.org/sao/rev/552889095191


New changeset 4cad1c465d8e by Cédric Krier in branch '4.8':
Connect only once wizard dialog to keydown
https://hg.tryton.org/sao/rev/4cad1c465d8e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766