Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 613002: product_attribute: New module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by ced
Modified:
5 years, 10 months ago
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix comments #

Patch Set 3 : Move attribute set to template #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1152 lines, -0 lines) Patch
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +30 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +12 lines, -0 lines 0 comments Download
A README View 1 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A doc/index.rst View 1 chunk +17 lines, -0 lines 0 comments Download
A product.py View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A product.xml View 1 2 1 chunk +110 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +81 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/test_product_attribute.py View 1 chunk +45 lines, -0 lines 0 comments Download
A tryton.cfg View 1 chunk +7 lines, -0 lines 0 comments Download
A view/attribute_form.xml View 1 chunk +15 lines, -0 lines 0 comments Download
A view/attribute_list.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/attribute_set_form.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/attribute_set_list.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A view/product_form.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A view/template_form.xml View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15
ced
6 years ago (2012-12-14 23:16:07 UTC) #1
yangoon
6 years ago (2012-12-15 00:04:58 UTC) #2
Sharoon Thomas
http://codereview.tryton.org/613002/diff/1/README File README (right): http://codereview.tryton.org/613002/diff/1/README#newcode4 README:4: The product module of the Tryton application platform. This ...
6 years ago (2012-12-15 05:10:49 UTC) #3
raimonesteve
http://codereview.tryton.org/613002/diff/1/product.py File product.py (right): http://codereview.tryton.org/613002/diff/1/product.py#newcode37 product.py:37: __name__ = 'product.product' product.product or product.template?
6 years ago (2012-12-15 09:08:44 UTC) #4
udono2
http://codereview.tryton.org/613002/diff/1/product.py File product.py (right): http://codereview.tryton.org/613002/diff/1/product.py#newcode38 product.py:38: set_ = fields.Many2One('product.attribute.set', 'Set') On 2012/12/15 05:10:49, Sharoon Thomas ...
6 years ago (2012-12-15 10:02:37 UTC) #5
ced
6 years ago (2012-12-15 10:38:57 UTC) #6
ced
http://codereview.tryton.org/613002/diff/1/product.py File product.py (right): http://codereview.tryton.org/613002/diff/1/product.py#newcode37 product.py:37: __name__ = 'product.product' On 2012/12/15 09:08:45, raimonesteve wrote: > ...
6 years ago (2012-12-15 10:40:52 UTC) #7
sharoon
On 2012/12/15 10:02:37, udono wrote: > http://codereview.tryton.org/613002/diff/1/product.py > File product.py (right): > > http://codereview.tryton.org/613002/diff/1/product.py#newcode38 > ...
6 years ago (2012-12-15 10:50:04 UTC) #8
sharoon
On 2012/12/15 10:02:37, udono wrote: > http://codereview.tryton.org/613002/diff/1/product.py > File product.py (right): > > http://codereview.tryton.org/613002/diff/1/product.py#newcode38 > ...
6 years ago (2012-12-15 10:50:06 UTC) #9
sharoon
On 2012/12/15 10:02:37, udono wrote: > http://codereview.tryton.org/613002/diff/1/product.py > File product.py (right): > > http://codereview.tryton.org/613002/diff/1/product.py#newcode38 > ...
6 years ago (2012-12-15 10:50:09 UTC) #10
sharoon
On 2012/12/15 10:02:37, udono wrote: > http://codereview.tryton.org/613002/diff/1/product.py > File product.py (right): > > http://codereview.tryton.org/613002/diff/1/product.py#newcode38 > ...
6 years ago (2012-12-15 10:50:11 UTC) #11
sharoon
On 2012/12/15 10:02:37, udono wrote: > http://codereview.tryton.org/613002/diff/1/product.py > File product.py (right): > > http://codereview.tryton.org/613002/diff/1/product.py#newcode38 > ...
6 years ago (2012-12-15 10:50:16 UTC) #12
sharoon
Oops, I had no intention of spamming, looks like a bug when using the code ...
6 years ago (2012-12-15 10:51:46 UTC) #13
raimonesteve
>> product.product or product.template? > I really think attribute should go to product as it ...
6 years ago (2012-12-15 13:04:01 UTC) #14
ced
6 years ago (2012-12-15 14:26:49 UTC) #15

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766