Issue 62371002: project_plan: Do not mix timedelta and float and compare duration together

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 62371002: project_plan: Do not mix timedelta and float and compare duration together

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 6 months ago by ced

Modified:
3 years, 6 months ago

Reviewers:
reviewbot

Visibility:
Public.

More Reviews

Description

Since changeset 0b309528f1f3, timedelta is used for duration instead of float hours. issue7799

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	work.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reviewbot

3 years, 6 months ago (2018-11-07 23:15:03 UTC) #2

https://codereview.tryton.org/62371002/diff/1/work.py#newcode261
work.py:261:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode263
work.py:263:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode265
work.py:265:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode266
work.py:266:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode446
work.py:446:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode471
work.py:471:
E731 do not assign a lambda expression, use a def

https://codereview.tryton.org/62371002/diff/1/work.py#newcode473
work.py:473:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/62371002

Expand All Messages | Collapse All Messages