Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(825)

Issue 62391002: trytond: Allow to search and order on Dict key value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
4 weeks, 1 day ago
Reviewers:
dave, reviewbot, rietveld-bot, jeremy, pokoli
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fix remarks #

Total comments: 2

Patch Set 3 : Update to tip #

Patch Set 4 : Update to tip #

Patch Set 5 : Update to tip #

Total comments: 4

Patch Set 6 : Better changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+812 lines, -23 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M doc/ref/models/fields.rst View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M doc/ref/models/models.rst View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M doc/topics/domain.rst View 1 2 chunks +14 lines, -6 lines 0 comments Download
M trytond/backend/database.py View 1 chunk +20 lines, -0 lines 0 comments Download
M trytond/backend/postgresql/database.py View 3 chunks +45 lines, -1 line 0 comments Download
M trytond/backend/sqlite/database.py View 3 chunks +17 lines, -1 line 0 comments Download
M trytond/model/fields/dict.py View 4 chunks +95 lines, -4 lines 0 comments Download
M trytond/tests/field_dict.py View 1 2 chunks +26 lines, -0 lines 0 comments Download
M trytond/tests/test_field_char.py View 2 chunks +14 lines, -8 lines 0 comments Download
M trytond/tests/test_field_dict.py View 1 2 5 chunks +572 lines, -2 lines 0 comments Download

Messages

Total messages: 22
ced
2 months, 1 week ago (2018-12-05 18:06:45 UTC) #1
reviewbot
https://codereview.tryton.org/62391002/diff/1/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/1/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
2 months, 1 week ago (2018-12-05 18:10:17 UTC) #2
dave
https://codereview.tryton.org/62391002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/1/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no more stored ...
2 months, 1 week ago (2018-12-05 18:43:47 UTC) #3
ced
Fix remarks
2 months, 1 week ago (2018-12-05 19:15:22 UTC) #4
reviewbot
https://codereview.tryton.org/62391002/diff/20001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/20001/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
2 months, 1 week ago (2018-12-05 19:17:15 UTC) #5
ced
https://codereview.tryton.org/62391002/diff/1/doc/topics/domain.rst File doc/topics/domain.rst (right): https://codereview.tryton.org/62391002/diff/1/doc/topics/domain.rst#newcode53 doc/topics/domain.rst:53: Ordering `date` and `datetime` value type is not supported. ...
2 months, 1 week ago (2018-12-05 21:34:47 UTC) #6
jeremy
https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py File trytond/tests/test_field_dict.py (right): https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py#newcode678 trytond/tests/test_field_dict.py:678: backend.name() != 'postgresql', 'jsonb only suported by postgresql') typo: ...
2 months, 1 week ago (2018-12-06 09:41:10 UTC) #7
ced
https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py File trytond/tests/test_field_dict.py (right): https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py#newcode678 trytond/tests/test_field_dict.py:678: backend.name() != 'postgresql', 'jsonb only suported by postgresql') On ...
2 months, 1 week ago (2018-12-06 10:06:07 UTC) #8
ced
Update to tip
1 month, 3 weeks ago (2018-12-21 22:54:28 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/62391002
1 month, 3 weeks ago (2018-12-21 23:15:33 UTC) #10
ced
Update to tip
1 month, 3 weeks ago (2018-12-21 23:33:17 UTC) #11
reviewbot
https://codereview.tryton.org/62391002/diff/60001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/60001/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
1 month, 3 weeks ago (2018-12-21 23:35:43 UTC) #12
ced
Update to tip
1 month, 2 weeks ago (2018-12-29 13:55:21 UTC) #13
reviewbot
https://codereview.tryton.org/62391002/diff/80001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/80001/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
1 month, 2 weeks ago (2018-12-29 14:09:04 UTC) #14
pokoli
https://codereview.tryton.org/62391002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/80001/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no longer stored ...
1 month ago (2019-01-11 18:27:46 UTC) #15
ced
https://codereview.tryton.org/62391002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/80001/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no longer stored ...
1 month ago (2019-01-11 18:41:18 UTC) #16
pokoli
https://codereview.tryton.org/62391002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/80001/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no longer stored ...
1 month ago (2019-01-11 20:45:19 UTC) #17
ced
https://codereview.tryton.org/62391002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/80001/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no longer stored ...
1 month ago (2019-01-11 21:17:43 UTC) #18
ced
Better changelog
1 month ago (2019-01-11 21:18:18 UTC) #19
reviewbot
https://codereview.tryton.org/62391002/diff/100001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/100001/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
1 month ago (2019-01-11 21:35:20 UTC) #20
rietveld-bot_tryton.org
New changeset 9a7247a6df7b by Cédric Krier in branch 'default': Allow to search and order on ...
4 weeks, 1 day ago (2019-01-18 10:33:04 UTC) #21
rietveld-bot_tryton.org
4 weeks, 1 day ago (2019-01-18 10:33:10 UTC) #22
New changeset c4b0c571128c by Cédric Krier in branch 'default':
Allow to search and order on Dict key value
https://hg.tryton.org/tryton-env/rev/c4b0c571128c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766