Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 62391002: trytond: Allow to search and order on Dict key value

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by ced
Modified:
1 week, 5 days ago
Reviewers:
dave, jeremy, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fix remarks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+810 lines, -21 lines) Patch
M CHANGELOG View 1 1 chunk +3 lines, -0 lines 0 comments Download
M doc/ref/models/fields.rst View 1 1 chunk +4 lines, -0 lines 0 comments Download
M doc/ref/models/models.rst View 1 1 chunk +2 lines, -1 line 0 comments Download
M doc/topics/domain.rst View 1 2 chunks +14 lines, -6 lines 0 comments Download
M trytond/backend/database.py View 1 chunk +20 lines, -0 lines 0 comments Download
M trytond/backend/postgresql/database.py View 3 chunks +45 lines, -1 line 0 comments Download
M trytond/backend/sqlite/database.py View 3 chunks +17 lines, -1 line 0 comments Download
M trytond/model/fields/dict.py View 4 chunks +95 lines, -4 lines 0 comments Download
M trytond/tests/field_dict.py View 1 2 chunks +26 lines, -0 lines 0 comments Download
M trytond/tests/test_field_char.py View 2 chunks +14 lines, -8 lines 0 comments Download
M trytond/tests/test_field_dict.py View 3 chunks +570 lines, -0 lines 2 comments Download

Messages

Total messages: 8
ced
1 week, 6 days ago (2018-12-05 18:06:45 UTC) #1
reviewbot
https://codereview.tryton.org/62391002/diff/1/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/1/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
1 week, 6 days ago (2018-12-05 18:10:17 UTC) #2
dave
https://codereview.tryton.org/62391002/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/62391002/diff/1/CHANGELOG#newcode3 CHANGELOG:3: * Keys with null value are no more stored ...
1 week, 6 days ago (2018-12-05 18:43:47 UTC) #3
ced
Fix remarks
1 week, 6 days ago (2018-12-05 19:15:22 UTC) #4
reviewbot
https://codereview.tryton.org/62391002/diff/20001/trytond/backend/postgresql/database.py#newcode6 trytond/backend/postgresql/database.py:6: E401 multiple imports on one line https://codereview.tryton.org/62391002/diff/20001/trytond/backend/postgresql/database.py#newcode490 trytond/backend/postgresql/database.py:490: E131 continuation line unaligned for ...
1 week, 6 days ago (2018-12-05 19:17:15 UTC) #5
ced
https://codereview.tryton.org/62391002/diff/1/doc/topics/domain.rst File doc/topics/domain.rst (right): https://codereview.tryton.org/62391002/diff/1/doc/topics/domain.rst#newcode53 doc/topics/domain.rst:53: Ordering `date` and `datetime` value type is not supported. ...
1 week, 6 days ago (2018-12-05 21:34:47 UTC) #6
jeremy
https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py File trytond/tests/test_field_dict.py (right): https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_dict.py#newcode678 trytond/tests/test_field_dict.py:678: backend.name() != 'postgresql', 'jsonb only suported by postgresql') typo: ...
1 week, 5 days ago (2018-12-06 09:41:10 UTC) #7
ced
1 week, 5 days ago (2018-12-06 10:06:07 UTC) #8
https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_di...
File trytond/tests/test_field_dict.py (right):

https://codereview.tryton.org/62391002/diff/20001/trytond/tests/test_field_di...
trytond/tests/test_field_dict.py:678: backend.name() != 'postgresql', 'jsonb
only suported by postgresql')
On 2018/12/06 09:41:10, jeremy wrote:
> typo: supported

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766