Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 62421002: tryton-env: Add origin on move line and product and category on analytic rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 2 weeks ago
Reviewers:
dave, semarie, reviewbot, rietveld-bot, pokoli
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Missing register MoveLine #

Total comments: 2

Patch Set 3 : Do not match empty product category #

Patch Set 4 : Fix matching product_category #

Patch Set 5 : Always fill pattern #

Total comments: 4

Patch Set 6 : wording #

Total comments: 2

Patch Set 7 : Use parent pattern and update to tip #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -7 lines) Patch
M modules/account/CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account/move.py View 4 chunks +21 lines, -3 lines 0 comments Download
M modules/account/tests/scenario_move_cancel.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M modules/account/view/move_line_form.xml View 1 chunk +3 lines, -1 line 0 comments Download
M modules/account/view/move_line_form_move.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account/view/move_line_list_payable_receivable.xml View 1 chunk +2 lines, -1 line 0 comments Download
M modules/account_invoice/CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_invoice/account.py View 2 chunks +15 lines, -0 lines 0 comments Download
M modules/account_invoice/invoice.py View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/account_product/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/account_product/__init__.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M modules/account_product/account.py View 1 2 3 4 5 6 2 chunks +26 lines, -2 lines 2 comments Download
A modules/account_product/analytic_account.py View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A modules/account_product/analytic_account.xml View 1 chunk +18 lines, -0 lines 0 comments Download
M modules/account_product/setup.py View 2 chunks +2 lines, -0 lines 0 comments Download
M modules/account_product/tests/test_account_product.py View 1 chunk +1 line, -0 lines 0 comments Download
M modules/account_product/tryton.cfg View 1 chunk +3 lines, -0 lines 0 comments Download
A modules/account_product/view/analytic_account_rule_form.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A modules/account_product/view/analytic_account_rule_list.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 32
ced
2 months, 1 week ago (2019-02-05 15:56:42 UTC) #1
ced
2 months, 1 week ago (2019-02-05 16:07:33 UTC) #2
reviewbot
https://codereview.tryton.org/62421002/diff/20001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/20001/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months, 1 week ago (2019-02-05 16:14:31 UTC) #3
semarie
one additional remark: with a rule with only product_category sets, analytic is added on all ...
2 months, 1 week ago (2019-02-07 10:54:21 UTC) #4
ced
2 months, 1 week ago (2019-02-07 11:48:03 UTC) #5
ced
On 2019/02/07 10:54:21, semarie wrote: > one additional remark: with a rule with only product_category ...
2 months, 1 week ago (2019-02-07 11:57:24 UTC) #6
ced
https://codereview.tryton.org/62421002/diff/20001/modules/account_product/analytic_account.py File modules/account_product/analytic_account.py (right): https://codereview.tryton.org/62421002/diff/20001/modules/account_product/analytic_account.py#newcode19 modules/account_product/analytic_account.py:19: and self.category.id not in categories): On 2019/02/07 10:54:21, semarie ...
2 months, 1 week ago (2019-02-07 11:57:28 UTC) #7
reviewbot
https://codereview.tryton.org/62421002/diff/40001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/40001/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months, 1 week ago (2019-02-07 12:19:33 UTC) #8
semarie
unsure about the origin, but with a rule with only product_category setted (should match only ...
2 months, 1 week ago (2019-02-07 13:42:37 UTC) #9
ced
2 months, 1 week ago (2019-02-07 14:01:14 UTC) #10
reviewbot
https://codereview.tryton.org/62421002/diff/60001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/60001/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months, 1 week ago (2019-02-07 14:20:41 UTC) #11
semarie
a rule with only product_category still match a Move from Statement (I have not tested ...
2 months, 1 week ago (2019-02-07 15:37:25 UTC) #12
ced
On 2019/02/07 15:37:25, semarie wrote: > a rule with only product_category still match a Move ...
2 months, 1 week ago (2019-02-07 16:10:00 UTC) #13
ced
2 months, 1 week ago (2019-02-07 16:10:36 UTC) #14
reviewbot
https://codereview.tryton.org/62421002/diff/60002/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/60002/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months, 1 week ago (2019-02-07 16:48:23 UTC) #15
dave
https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG File modules/account_invoice/CHANGELOG (right): https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG#newcode1 modules/account_invoice/CHANGELOG:1: * Fill origin of move line A very minor ...
2 months, 1 week ago (2019-02-07 18:06:27 UTC) #16
ced
https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG File modules/account_invoice/CHANGELOG (right): https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG#newcode1 modules/account_invoice/CHANGELOG:1: * Fill origin of move line On 2019/02/07 18:06:27, ...
2 months, 1 week ago (2019-02-07 18:24:37 UTC) #17
dave
https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG File modules/account_invoice/CHANGELOG (right): https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG#newcode1 modules/account_invoice/CHANGELOG:1: * Fill origin of move line On 2019/02/07 18:24:37, ...
2 months, 1 week ago (2019-02-07 20:50:46 UTC) #18
ced
https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG File modules/account_invoice/CHANGELOG (right): https://codereview.tryton.org/62421002/diff/60002/modules/account_invoice/CHANGELOG#newcode1 modules/account_invoice/CHANGELOG:1: * Fill origin of move line On 2019/02/07 20:50:45, ...
2 months, 1 week ago (2019-02-07 22:57:50 UTC) #19
ced
2 months, 1 week ago (2019-02-07 22:58:04 UTC) #20
reviewbot
https://codereview.tryton.org/62421002/diff/90001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/90001/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months, 1 week ago (2019-02-07 23:10:37 UTC) #21
semarie
https://codereview.tryton.org/62421002/diff/90001/modules/account_product/account.py File modules/account_product/account.py (right): https://codereview.tryton.org/62421002/diff/90001/modules/account_product/account.py#newcode60 modules/account_product/account.py:60: c.id for c in self.product.categories_all] with such construct, we ...
2 months ago (2019-02-13 12:51:34 UTC) #22
ced
2 months ago (2019-02-14 10:20:54 UTC) #23
ced
https://codereview.tryton.org/62421002/diff/90001/modules/account_product/account.py File modules/account_product/account.py (right): https://codereview.tryton.org/62421002/diff/90001/modules/account_product/account.py#newcode60 modules/account_product/account.py:60: c.id for c in self.product.categories_all] On 2019/02/13 12:51:34, semarie ...
2 months ago (2019-02-14 10:23:13 UTC) #24
reviewbot
https://codereview.tryton.org/62421002/diff/110001/modules/account/move.py#newcode81 modules/account/move.py:81: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/62421002/diff/110001/modules/account/move.py#newcode415 modules/account/move.py:415: E731 do not assign ...
2 months ago (2019-02-14 10:45:56 UTC) #25
pokoli
https://codereview.tryton.org/62421002/diff/110001/modules/account_product/account.py File modules/account_product/account.py (left): https://codereview.tryton.org/62421002/diff/110001/modules/account_product/account.py#oldcode8 modules/account_product/account.py:8: __all__ = ['CreateChart', 'CreateChartProperties'] why removing?
1 month, 2 weeks ago (2019-03-01 09:10:13 UTC) #26
ced
https://codereview.tryton.org/62421002/diff/110001/modules/account_product/account.py File modules/account_product/account.py (left): https://codereview.tryton.org/62421002/diff/110001/modules/account_product/account.py#oldcode8 modules/account_product/account.py:8: __all__ = ['CreateChart', 'CreateChartProperties'] On 2019/03/01 09:10:13, pokoli wrote: ...
1 month, 2 weeks ago (2019-03-01 09:43:39 UTC) #27
pokoli
LGTM
1 month, 2 weeks ago (2019-03-01 15:08:52 UTC) #28
rietveld-bot_tryton.org
New changeset 287225cee91b by Cédric Krier in branch 'default': Add origin on move line and ...
1 month, 2 weeks ago (2019-03-03 22:06:39 UTC) #29
rietveld-bot_tryton.org
New changeset dc947bc9e61b by Cédric Krier in branch 'default': Add origin on move line and ...
1 month, 2 weeks ago (2019-03-03 22:06:42 UTC) #30
rietveld-bot_tryton.org
New changeset fd01fc412adc by Cédric Krier in branch 'default': Add origin on move line and ...
1 month, 2 weeks ago (2019-03-03 22:06:47 UTC) #31
rietveld-bot_tryton.org
1 month, 2 weeks ago (2019-03-03 22:06:53 UTC) #32
New changeset b604e315d8ed by Cédric Krier in branch 'default':
Add origin on move line and product and category on analytic rule
https://hg.tryton.org/tryton-env/rev/b604e315d8ed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766